This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Support extracting more modelTypeId in luis:test command - #1229
Merged
Shuai Wang (cosmicshuai) merged 5 commits intoMay 18, 2021
Merged
Support extracting more modelTypeId in luis:test command#1229Shuai Wang (cosmicshuai) merged 5 commits into
Shuai Wang (cosmicshuai) merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Shuai Wang (cosmicshuai)
requested a review
from Emilio Munoz (munozemilio)
as a code owner
May 6, 2021 09:13
Shuai Wang (cosmicshuai)
marked this pull request as draft
May 6, 2021 09:21
Shuai Wang (cosmicshuai)
marked this pull request as ready for review
May 10, 2021 02:00
Emilio Munoz (munozemilio)
approved these changes
May 17, 2021
Copy link
Copy Markdown
Contributor
|
Should we add a test? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
I slightly modified a test to cover the case when the modelTypeId is 10 |
Sorry, something went wrong.
This was referenced Dec 31, 2021
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Jun 21, 2023
This was referenced Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, in luis:test, only those entities with modelTypeId is 1 or 4, or those entities have roles will be included.
botframework-cli/packages/lu/src/parser/test/testhelper.ts
Line 108 in 968ef75
In this PR, all modelTypeId 1 or 4 or 10, or those entities have roles will be included.