FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix import filtered intents not work in luis:cross-train by cosmicshuai · Pull Request #1232 · microsoft/botframework-cli · GitHub

This repository was archived by the owner on Jan 15, 2025. It is now read-only.
/ botframework-cli Public archive

fix import filtered intents not work in luis:cross-train - #1232

Merged
Emilio Munoz (munozemilio) merged 14 commits into
mainfrom
shuwan/fixFilterIntent
Jun 3, 2021
ConversationCommits (14)ChecksFiles changed
Merged

fix import filtered intents not work in luis:cross-train#1232
Emilio Munoz (munozemilio) merged 14 commits into
mainfrom
shuwan/fixFilterIntent

Conversation

Shuai Wang (cosmicshuai) commented May 11, 2021

Copy link
Copy Markdown
Contributor

closes: #1210
In this PR, for the test cases of using imported intents User report case will only includes the referenced intents in the generated files.

Here is the new result of Cross-train for that case above:

> LUIS application information
> !# @app.versionId = 0.1
> !# @app.culture = en-us
> !# @app.luis_schema_version = 3.2.0


> # Intent definitions

# InternalIntent
- Intent within application.lu


# ExternalIntentShouldBeIncluded
- Intent which should be included


> # Entity definitions


> # PREBUILT Entity definitions


> # Phrase list definitions


> # List entities

> # RegEx entities

Shuai Wang (cosmicshuai) marked this pull request as ready for review May 12, 2021 05:40
Emilio Munoz (munozemilio) suggested changes May 17, 2021
View reviewed changes

Emilio Munoz (munozemilio) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Small comment on code optimization

Josh Gummersall (joshgummersall) reviewed May 26, 2021
View reviewed changes
Comment thread packages/lu/src/parser/cross-train/cross-train.js Outdated

const matchedUtterence = luObj.utterances.find(e => e.intent === intent)
const fileContent = `# ${intent}\r\n${parseUtterancesToLu([matchedUtterence], luObj)}`
let cloned = {...(isAbsolutePath ? importFile : filePathOrFound[0])}

Josh Gummersall (joshgummersall) May 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

const, also does this need to be a deep clone?

Shuai Wang (cosmicshuai) May 27, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The reason I used a deep clone here is due to I don't want to change the original content of luis and qna files.

Josh Gummersall (joshgummersall) May 27, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This isn't a deep clone actually, that was my question. See Typescript playground for explanataion.

Shuai Wang (cosmicshuai) May 28, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I see. I just fixed this.

Snyk bot (snyk-bot) mentioned this pull request Aug 19, 2022
Open
Open
Snyk bot (snyk-bot) mentioned this pull request Aug 19, 2022
Open
This was referenced Aug 19, 2022
Open
Open
This was referenced Aug 19, 2022
Open
Open
This was referenced Jun 21, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 30, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Chris Mullins (cleemullins) Awaiting requested review from cleemullins
2 more reviewers
Josh Gummersall (joshgummersall) joshgummersall approved these changes
Emilio Munoz (munozemilio) munozemilio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bf luis:cross-train not working as expected when using external file references which use intent filter

3 participants

Back | FazBrowse Home | New Git URL