This repository was archived by the owner on Jan 15, 2025. It is now read-only.
syncLabelResolverEx should return after addBatch - #1266
Merged
Emilio Munoz (munozemilio) merged 2 commits intoJul 8, 2021
Merged
syncLabelResolverEx should return after addBatch#1266Emilio Munoz (munozemilio) merged 2 commits into
Emilio Munoz (munozemilio) merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Return after addBatch
Tien Suwandy (tsuwandy)
requested a review
from Emilio Munoz (munozemilio)
as a code owner
July 7, 2021 22:45
Comment thread
packages/orchestratorlib/src/build.ts
| Utility.debuggingLog('OrchestratorBuild.syncLabelResolverEx(), ready to call LabelResolver.addBatch()'); | ||
| LabelResolver.addBatch(target); | ||
| Utility.debuggingLog('OrchestratorBuild.syncLabelResolverEx(), after calling LabelResolver.addBatch()'); | ||
| return; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Should we add a test to catch this scenario?
Sorry, something went wrong.
daveta
approved these changes
Jul 7, 2021
Hung-chih Yang (hcyang)
approved these changes
Jul 7, 2021
Emilio Munoz (munozemilio)
suggested changes
Jul 7, 2021
Emilio Munoz (munozemilio)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
If this was not caught by the tests, maybe we should add one
Sorry, something went wrong.
Emilio Munoz (munozemilio)
approved these changes
Jul 8, 2021
Tien Suwandy (tsuwandy)
added a commit
that referenced
this pull request
Jul 8, 2021
* Update build.ts Return after addBatch * Update create.test.ts
Tien Suwandy (tsuwandy)
added a commit
that referenced
this pull request
Jul 8, 2021
* Update build.ts Return after addBatch * Update create.test.ts
Emilio Munoz (munozemilio)
pushed a commit
that referenced
this pull request
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1262