This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Fixing output file path messages - #296
Merged
Emilio Munoz (munozemilio) merged 1 commit intoOct 29, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Emilio Munoz (munozemilio)
requested review from
Axel Suárez (axelsrz) and
Christopher Anderson (christopheranderson)
October 29, 2019 20:27
Christopher Anderson (christopheranderson)
approved these changes
Oct 29, 2019
Christopher Anderson (christopheranderson)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
some nits but 🚢
Sorry, something went wrong.
Comment thread
packages/config/src/commands/config/index.ts
|
|
||
| import {Command, flags} from '@oclif/command' | ||
|
|
||
| const path = require('path') |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: why not use import?
Sorry, something went wrong.
Comment thread
packages/lu/src/commands/qnamaker/convert.ts
| let filePathAlterations = await file.generateNewFilePath(flags.out, flags.in, isQnA, 'alterations_', fileExtEnum.QnAFile) | ||
| let validatedPath = utils.validatePath(filePathAlterations, '', flags.force) | ||
| await fs.writeFile(validatedPath, JSON.stringify(convertedObject.finalQnAAlterations, null, 2), 'utf-8') | ||
| const validatedPathAlter = utils.validatePath(filePathAlterations, '', flags.force) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: validatedPathAlter is less readable than validatedAlterationsPath
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.