This repository was archived by the owner on May 20, 2025. It is now read-only.
Fix vm2 vulnerability: remove superagent-proxy dependency - #830
Merged
Dmitriy Kirakosyan (DmitriyKirakosyan) merged 5 commits intoAug 16, 2023
Merged
Fix vm2 vulnerability: remove superagent-proxy dependency#830Dmitriy Kirakosyan (DmitriyKirakosyan) merged 5 commits into
Dmitriy Kirakosyan (DmitriyKirakosyan) merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Dmitriy Kirakosyan (DmitriyKirakosyan)
requested a review
from a team
as a code owner
August 3, 2023 10:14
Comment thread
src/utils/request-manager.ts
Outdated
|
|
||
| var superproxy = require("superagent-proxy"); | ||
| superproxy(superagent); | ||
| import superagent_setup from "./superagent-proxy.js"; |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Why don't we directly use proxy-agent here?
Sorry, something went wrong.
Dmitriy Kirakosyan (DmitriyKirakosyan)
force-pushed
the
fix/vm2
branch
from
c873ba9 to
7f2fbfb
Compare
August 15, 2023 07:50
Lukas Cenovsky (lucen-ms)
approved these changes
Aug 16, 2023
This was referenced Aug 16, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove the superagent-proxy package, as it's not maintained anymore and depends on the vulnerable vm2 package.
agent-proxy is used directly with superagent's Request object now.
AB#101666