Use sarif v2.1.0 instead of sarif v2.0.0 - #39
Open
gero3 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Michael Scovetta (scovetta)
approved these changes
Jan 23, 2023
Michael Scovetta (scovetta)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, thanks for the fix!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Suraj Jacob (@jacobmsft) LMK if this one is good to merge. |
Sorry, something went wrong.
Copy link
Copy Markdown
LGTM Michael Scovetta (@scovetta), thanks gero3 for the fix! |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I was reviewing my old PRs and noticed this one is still open. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that new users don't use a deprecated version of sarif. sarif v2.0.0 is fully deprecated which isn't very usable in vscode for instance.