chore: Update acr script to handle WAF deployment - #649
Merged
Roopan-Microsoft merged 4 commits intoJul 8, 2026
Merged
Roopan-Microsoft merged 4 commits into
Roopan-Microsoft merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chaudhariniraj
requested review from
Avijit-Microsoft,
Prajwal1-Microsoft,
Roopan-Microsoft,
VinaySh-Microsoft,
Anish Arora (aniaroramsft),
dgp10801,
nchandhi and
Todd Herman (toherman-msft)
as code owners
July 6, 2026 07:06
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ACR build/push automation scripts to detect WAF deployments (via the resource group tags.Type) and temporarily relax ACR network/export restrictions during image build/push, then restore the previous (expected) locked-down configuration afterward.
Changes:
- Detect WAF deployments by querying the resource group tag Type.
- Temporarily relax ACR settings (allow-exports, public-network-enabled, default-action) for WAF deployments.
- Add cleanup/rollback logic (trap in Bash; try/finally in PowerShell) to restore ACR restrictions at script exit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| infra/scripts/acr_build_push.sh | Adds WAF detection and ACR relax/restore logic via az acr update and an EXIT trap. |
| infra/scripts/acr_build_push.ps1 | Adds WAF detection and ACR relax/restore logic via az acr update and try/finally. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
infra/scripts/acr_build_push.sh
Comment thread
infra/scripts/acr_build_push.sh
Comment thread
infra/scripts/acr_build_push.ps1
Comment thread
infra/scripts/acr_build_push.ps1
Outdated
Comment thread
infra/scripts/acr_build_push.ps1
Comment thread
infra/scripts/acr_build_push.ps1
Comment thread
infra/modules/container-registry.bicep
Outdated
Roopan-Microsoft
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update acr script to handle WAF deployment
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information