FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: dev container version issue by PadhiAjit-Microsoft · Pull Request #705 · microsoft/content-processing-solution-accelerator · GitHub

fix: dev container version issue - #705

Merged
Roopan-Microsoft merged 1 commit into
devfrom
container-issue-fix
Sep 21, 2026
Merged

Roopan-Microsoft merged 1 commit into
devfrom
container-issue-fix

Conversation

Copy link
Copy Markdown
Contributor

Purpose

  • This pull request makes minor updates to the development container configurations for both the ContentProcessorWeb and ContentProcessorWorkflow projects. The main changes involve updating the base images and cleaning up comments related to Node.js version selection.

Development container image updates:

  • Changed the Python devcontainer image in ContentProcessorWorkflow from 3.12-bullseye to 3.12-bookworm for a more recent Debian base.
  • Updated the Node.js devcontainer base image reference in ContentProcessorWeb/.devcontainer/base.Dockerfile to use javascript-node instead of typescript-node.
  • Removed outdated Node.js version selection comments from ContentProcessorWeb/.devcontainer/devcontainer.json and Dockerfile for clarity and maintainability. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot review overview

🟡 Changes recommended

The PR description claims a Node.js base-image update that is not included in the reviewed diff.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1) What changed in this PR

Updates development container configurations by moving the workflow image to Debian Bookworm and removing outdated Node.js version comments.

Changes:

  • Updates the Python devcontainer base image.
  • Removes obsolete Node.js version-selection comments.
  • The described Node.js image change is not present in the diff.
File Description
src/​ContentProcessorWorkflow/​.devcontainer/​devcontainer.json Switches Python image to Bookworm.
src/​ContentProcessorWeb/​.devcontainer/​Dockerfile Removes outdated version guidance.
src/​ContentProcessorWeb/​.devcontainer/​devcontainer.json Removes obsolete configuration comments.
src/​ContentProcessorWeb/​.devcontainer/​base.Dockerfile Removes outdated version guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Roopan-Microsoft merged commit 3fab586 into dev Sep 21, 2026
3 checks passed
PadhiAjit-Microsoft deleted the container-issue-fix branch September 21, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL