Use optional for nullable input object resolver arguments by Copilot · Pull Request #364 · microsoft/cppgraphqlgen · GitHub

Nullable input objects could produce mismatched resolver signatures and conversions, particularly for fields returning built-in scalars. Generated code declared std::optional<T> but passed std::unique_ptr<T>, causing compilation failures.

Argument classification
- Classify field arguments before handling built-in return types.
Type generation
- Use std::optional<T> consistently for nullable input-object resolver arguments.
- Preserve std::unique_ptr<T> for recursive input-object members.

getField0(FieldParams&&, std::optional<Type>&&);
getField1(FieldParams&&, std::optional<Type>&&);

Regression coverage
- Cover nullable input objects on both scalar- and object-returning fields.

Fixes Error compiling in resolve function #354

…c headers

Groundwork in CMake, build workflows, and header include cleanup

Add enum value validation

chore: regenerate samples with enum validation

…o next

…e-337

Co-authored-by: wravery <6502881+wravery@users.noreply.github.com>

…piling-resolve-function # Conflicts: # cmake/version.txt # include/SchemaGenerator.h # include/SchemaLoader.h # include/graphqlservice/GraphQLParse.h # include/graphqlservice/internal/Version.h # res/ClientGen.rc # res/SchemaGen.rc # res/graphqlclient_version.rc # res/graphqljson_version.rc # res/graphqlpeg_version.rc # res/graphqlresponse_version.rc # res/graphqlservice_version.rc # src/SchemaGenerator.cpp # src/SyntaxTree.cpp Co-authored-by: wravery <6502881+wravery@users.noreply.github.com>

Co-authored-by: wravery <6502881+wravery@users.noreply.github.com>

Bill Avery (wravery) and others added 30 commits September 10, 2024 13:29

chore(modules): bump minimum CMake version for modules support

17dcab0

chore(modules): make macOS build action use Ninja instead of makefiles

b152a94

chore(modules): add vcpkg submodule and update workflows

cc88694

chore(modules): workflow fixes

10391bb

chore(modules): rewind vcpkg submodule to match baseline.json

8aad123

chore(modules): try universe PPA on ubuntu-latest

3a6166a

fix(workflow): try synchronizing the submodule with manifest baseline

ab729b2

fix(workflow): try fetching all history in checkout

f54f040

fix(workflow): hash vcpkg.json manifest in cache key

743fb91

fix(workflow): remove old arch from macos cache key

b045094

fix(vcpkg): rollback submodule to match vcpkg distributed with VS

1c77733

fix(cmake): opt-in to CMP0167 BoostConfig.cmake policy in 3.30

c0831b7

fix(cmake): use the right variable exported from BoostConfig.cmake

8553608

fix(includes): get rid of dependencies from internal headers on publi…

8f7aabb

…c headers

fix(includes): missing standard headers

7dc77fa

Merge pull request #312 from wravery/next

e9c7081

Groundwork in CMake, build workflows, and header include cleanup

fix: replace C-style size_t with std::size_t

64452a3

chore(cleanup): remove support for experimental coroutines

1996b5a

chore(modules): try building internal headers as modules

1d24695

fix(cmake): update the check_coroutine_impl function

decc8e6

fix(buiild): remove duplicate includes and specify C++20

1d3a536

fix(modules): consistent Internal.Version module usage

a9120e4

fix(includes): move redundant headers to header that uses them

591275a

fix: ignore vc140.pdb that VS keeps dropping

836e5b1

fix(includes): try moving all imports after system includes

85053f5

chore: disable macOS build on each push

0e74aae

feat(modules): finish wrapping modules around headers

e587a4b

chore(cmake): install headers and module interfaces together

7e8d6f8

chore(modules): move primary interface to internal/Module.ixx

bf6b48d

fix(modules): separate modules instead of partitioning for ICE

5980cb9

Rafał Hibner and others added 16 commits November 21, 2024 13:54

Update generated files

f7cfbc5

Fix list of boolean argument

523d16f

Merge pull request #336 from gitmodimo/issues-334

2cfdc5b

Add enum value validation

chore: regenerate samples with enum validation

e48538f

Merge pull request #339 from wravery/next

b61e0d5

chore: regenerate samples with enum validation

Merge branch 'main' of https://github.com/microsoft/cppgraphqlgen int…

7fb19c2

…o next

fix(merge): regenerate samples after merge

3643116

Merge remote-tracking branch 'gitmodimo/input-boolean-list' into merg…

dce7c1f

…e-337

fix: handle potential modifiers on bool lists

29ccf43

Merge pull request #341 from wravery/merge-337

f5fa468

chore(deps): update PEGTL sub-module to 3.2.8

876b0cb

fix(build): build today and stitched samples without modules

10d1124

fix: #338

8e0aa14

fix: update test for new sample field

9bf6d47

Merge pull request #342 from wravery/next

98d1229

Initial plan

fd64cc5

Copilot AI assigned Copilot and Bill Avery (wravery) Sep 15, 2026

Copilot started work on behalf of Bill Avery (wravery) September 15, 2026 20:58 View session

Copilot AI linked an issue Sep 15, 2026 that may be closed by this pull request

Error compiling in resolve function #354

Open

Use optional for nullable input arguments

a841bf0

Co-authored-by: wravery <6502881+wravery@users.noreply.github.com>

Copilot AI changed the title [WIP] Fix error compiling in resolve function Use optional for nullable input object resolver arguments Sep 15, 2026

Copilot finished work on behalf of Bill Avery (wravery) September 15, 2026 21:18

Copilot AI requested a review from Bill Avery (wravery) September 15, 2026 21:18

Copilot started work on behalf of Bill Avery (wravery) September 15, 2026 21:35 View session

Copilot AI and others added 2 commits September 15, 2026 21:37

Adapt nullable input fix to next

400653c

Co-authored-by: wravery <6502881+wravery@users.noreply.github.com>

Copilot finished work on behalf of Bill Avery (wravery) September 15, 2026 22:17

Copilot started work on behalf of Bill Avery (wravery) September 15, 2026 22:17 View session

Copilot finished work on behalf of Bill Avery (wravery) September 15, 2026 22:31

Use optional for nullable input object resolver arguments by Copilot · Pull Request #364 · microsoft/cppgraphqlgen · GitHub

Use optional for nullable input object resolver arguments - #364

Use optional for nullable input object resolver arguments#364
Bill Avery (wravery) with Copilot wants to merge 147 commits into
mainfrom
copilot/fix-error-compiling-resolve-function

Copilot AI commented Sep 15, 2026 •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Use optional for nullable input object resolver arguments by Copilot · Pull Request #364 · microsoft/cppgraphqlgen · GitHub

Use optional for nullable input object resolver arguments - #364

Conversation

Copilot AI commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Sep 15, 2026 •
edited
Loading