FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove explicitly setting PreferredToolArchitecture, since VS 2022 handles this more comprehensively by Scottj1s · Pull Request #1304 · microsoft/cppwinrt · GitHub

/ cppwinrt Public

Remove explicitly setting PreferredToolArchitecture, since VS 2022 handles this more comprehensively - #1304

Merged
Scott Jones (Scottj1s) merged 1 commit into
masterfrom
scottj1s/remove_PreferredToolArchitecture
May 15, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Remove explicitly setting PreferredToolArchitecture, since VS 2022 handles this more comprehensively#1304
Scott Jones (Scottj1s) merged 1 commit into
masterfrom
scottj1s/remove_PreferredToolArchitecture

Conversation

Scott Jones (Scottj1s) commented May 15, 2023

Copy link
Copy Markdown
Member

fixes #1302

With VS 2022, PreferredToolArchitecture is now set appropriately for every architecture (via Microsoft.Cpp.ToolsetLocation.props), so should no longer be set unconditionally by C++/WinRT

David Machaj (dmachaj) reviewed May 15, 2023
View reviewed changes
Comment thread nuget/Microsoft.Windows.CppWinRT.props
</PropertyGroup>

<PropertyGroup>
<PreferredToolArchitecture>x64</PreferredToolArchitecture>

David Machaj (dmachaj) May 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should this be scoped to the VS2022 build tools (so that VS2019 still gets it set)?

David Machaj (dmachaj) May 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Or the opposite; only set it for VS2019 and then VS2022+ do not set it because VS does the right thing already.

Kenny Kerr (kennykerr) May 15, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think the latest version of cppwinrt supports the 2019 compiler any longer.

David Machaj (dmachaj) May 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, nevermind then.

Scott Jones (Scottj1s) May 15, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's actually a bug to set it in VS2019 when building for ARM64 (reported elsewhere). And since it's just a build optimization, I think better to remove it altogether, than to effectively copy the intelligence in the VS 2022 Microsoft.Cpp.ToolsetLocation.props.

Scott Jones (Scottj1s) merged commit 4587264 into master May 15, 2023
Scott Jones (Scottj1s) deleted the scottj1s/remove_PreferredToolArchitecture branch May 15, 2023 18:19
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Kenny Kerr (kennykerr) kennykerr approved these changes
David Machaj (dmachaj) dmachaj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: PreferredToolArchitecture x64 should default, not override, conditionally for x86

3 participants

Back | FazBrowse Home | New Git URL