Fix vpack clobbering and update to newer Windows container image - #1480
Merged
Ryan Shepherd (DefaultRyan) merged 3 commits intoMar 3, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Ryan Shepherd (DefaultRyan)
requested review from
Scott Jones (Scottj1s) and
Manodasan Wignarajah (manodasanW)
March 3, 2025 20:26
Scott Jones (Scottj1s)
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that after #1479 a left overline in the msbuild vpack copy was clobbering the compiler contents we had previously copied over. Didn't notice until I tried to use the new vpack and cppwinrt.exe was missing.
While we're at it, let's go ahead and update our pipeline container images from 2019 to the latest (and recommended) 2022 version.