Update target platform to more closely follow JDT-LS. - #585
Update target platform to more closely follow JDT-LS.#585Jinbo Wang (testforstephen) merged 1 commit into
Conversation
Sorry, something went wrong.
- Update Apache Commons IO from 2.11.0 to 2.19.0 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Jinbo Wang (testforstephen)
left a comment
There was a problem hiding this comment.
LGTM. thanks for contribution.
Sorry, something went wrong.
|
Hi! 👋 Jinbo Wang (@testforstephen) Since this patch is important for the OpenShift Dev Spaces product and directly affects our delivery timeline, could I please ask for a new release of java-debug and vscode-java-debug with this change included? It would really help us move forward and integrate the fix promptly. |
Sorry, something went wrong.
|
Valerii Svydenko (@svor) sure, I will make some test tomorrow. if everything is fine and I will trigger a release for this. |
Sorry, something went wrong.
java-debug is a bundle contributed into the JDT-LS runtime. This means that it has no control over any dependencies it dos not contribute into the runtime itself (all of them). So when java-debug defines a target platform with dependencies that don't reference the same ones JDT-LS does, it is masking any potential runtime problems. This is the same issue we ran into on LSP4MP / quarkus-ls. The project will compile just fine and fail at runtime because the target platform is not reflective of runtime.
The solution is to reference the exact bundles JDT-LS is using (ie. the latest ones), at https://download.eclipse.org/jdtls/snapshots/repository/latest/plugins/ .