FEAT: Export Row class and refactor __init__.py (#270) - #474
Merged
Jahnvi Thakkar (jahnvi480) merged 7 commits intoMar 12, 2026
Merged
FEAT: Export Row class and refactor __init__.py (#270)#474Jahnvi Thakkar (jahnvi480) merged 7 commits into
Jahnvi Thakkar (jahnvi480) merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- Export Row class from __init__.py so users can type hint with it - Extract decimal separator logic into decimal_config.py module - Auto-export SQL/GetInfo/AuthType constants from constants.py - Replace manual constant assignments in __init__.py with wildcard import
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors mssql_python/__init__.py by: (1) exporting the Row class at the top level (addressing issue #270), (2) moving decimal separator logic to a new decimal_config.py module using a factory pattern, and (3) replacing manual, per-constant assignments with dynamic enum-driven exports and a wildcard import in __init__.py.
Changes:
- New decimal_config.py module encapsulating decimal separator getter/setter logic with a factory function
- constants.py extended with dynamic module-level exports for ConstantsDDBC, GetInfoConstants, and AuthType members, plus get_info_constants function moved here
- __init__.py simplified by removing manual constant assignments, adding Row export, and using from .constants import *
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| mssql_python/decimal_config.py | New module providing factory-based decimal separator getter/setter functions |
| mssql_python/constants.py | Adds dynamic module-level constant exports for enums and get_info_constants() |
| mssql_python/__init__.py | Removes manual constant assignments; adds Row export; uses wildcard import from constants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
mssql_python/constants.py
Outdated
Comment thread
mssql_python/__init__.py
Comment thread
mssql_python/__init__.py
Outdated
Comment thread
mssql_python/decimal_config.py
Outdated
Copy link
Copy Markdown
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changes
Summary
📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 67.8%
mssql_python.pybind.ddbc_bindings.cpp: 69.7%
mssql_python.row.py: 70.5%
mssql_python.pybind.connection.connection.cpp: 75.3%
mssql_python.__init__.py: 77.1%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 85.2%🔗 Quick Links
|
Sorry, something went wrong.
- Remove AuthType individual member exports to avoid namespace pollution - Add test_row_export to verify Row class is properly exported - Add test_get_info_constants to cover constants.py:530 - Add test_decimal_config_import_error_fallback for ImportError branch - Remove unused Dict import from __init__.py - Remove unreachable dead code in decimal_config.py - Add pragma: no cover to TYPE_CHECKING guard
Gaurav Sharma (bewithgaurav)
previously approved these changes
Mar 12, 2026
Comment thread
mssql_python/__init__.py
Outdated
Comment thread
mssql_python/decimal_config.py
Outdated
Sumit Sarabhai (sumitmsft)
previously approved these changes
Mar 12, 2026
Sumit Sarabhai (sumitmsft)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Approved with minor changes
Sorry, something went wrong.
Jahnvi Thakkar (jahnvi480)
dismissed stale reviews from Gaurav Sharma (bewithgaurav) and Sumit Sarabhai (sumitmsft)
via
1db59ea
March 12, 2026 10:57
Gaurav Sharma (bewithgaurav)
approved these changes
Mar 12, 2026
Sumit Sarabhai (sumitmsft)
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request refactors how module-level constants and decimal separator configuration are handled in the mssql_python package. Constants are now dynamically exported from the constants module, and decimal separator functions are moved to a dedicated module for improved maintainability and clarity. The changes also add new exports for row objects and simplify imports.
Module-level constant export and API improvements:
Decimal separator configuration refactor:
API and import enhancements:
These changes improve the maintainability, clarity, and usability of the package's public API and configuration options.