FIX: Credential instance cache - #483
Merged
Jahnvi Thakkar (jahnvi480) merged 11 commits intoApr 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds module-level caching of Azure Identity credential instances in mssql_python AAD auth flows to reduce repeated credential construction and enable Azure Identity’s in-memory token caching, along with new tests and a benchmark for measuring the impact.
Changes:
- Added a module-level credential instance cache (with locking) used by AADAuth._acquire_token() / get_raw_token().
- Expanded auth test coverage to validate credential reuse and additional error/edge paths.
- Added a benchmark script to compare “new credential per call” vs “cached credential instance” token acquisition.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| mssql_python/auth.py | Introduces a global credential-instance cache guarded by a lock and updates token acquisition to reuse credentials. |
| tests/test_008_auth.py | Adds cache-clearing fixture and new tests for credential reuse, import-error handling, and edge cases. |
| benchmarks/bench_credential_cache.py | Adds a standalone benchmark script to quantify the performance effect of credential-instance caching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
benchmarks/bench_credential_cache.py
Comment thread
benchmarks/bench_credential_cache.py
Comment thread
benchmarks/bench_credential_cache.py
Copy link
Copy Markdown
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changes
Summary
📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 67.8%
mssql_python.row.py: 70.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 73.9%
mssql_python.pybind.connection.connection.cpp: 75.3%
mssql_python.__init__.py: 77.3%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 85.2%🔗 Quick Links
|
Sorry, something went wrong.
Comment thread
mssql_python/auth.py
Comment thread
tests/test_008_auth.py
Sumit Sarabhai (sumitmsft)
requested changes
Apr 1, 2026
gargsaumya
approved these changes
Apr 6, 2026
Sumit Sarabhai (sumitmsft)
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request introduces credential instance caching for Azure Active Directory (AAD) authentication in the mssql_python package, improving performance by reusing credential objects instead of creating new ones for each token request. It also adds comprehensive tests for the caching logic and edge cases, and includes a new benchmark script to measure the performance impact of credential caching.
Credential instance caching and logic changes:
Testing improvements:
Benchmarking: