FIX: Add manylinux_2_28 build targets for RHEL 8 / glibc 2.28 compatibility - #548
Merged
gargsaumya merged 6 commits intoMay 11, 2026
Merged
FIX: Add manylinux_2_28 build targets for RHEL 8 / glibc 2.28 compatibility#548gargsaumya merged 6 commits into
gargsaumya merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the OneBranch Linux wheel build matrix to include manylinux_2_28 (glibc 2.28 / RHEL 8–compatible) alongside the existing glibc-based manylinux build and musllinux builds.
Changes:
- Add manylinux_2_28 (x86_64 + aarch64) to the Linux build configuration matrix.
- Update Linux stage template to select the correct Docker image for manylinux_2_28.
- Update shell/command conditionals so manylinux_2_28 follows the same bash-based execution path as the existing manylinux builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| OneBranchPipelines/stages/build-linux-single-stage.yml | Adds manylinux_2_28 container image selection and treats it like manylinux for bash-based steps. |
| OneBranchPipelines/build-release-package-pipeline.yml | Expands the Linux build matrix to include manylinux_2_28 for both architectures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
OneBranchPipelines/build-release-package-pipeline.yml
Outdated
Comment thread
OneBranchPipelines/build-release-package-pipeline.yml
Outdated
Comment thread
OneBranchPipelines/stages/build-linux-single-stage.yml
Outdated
Comment thread
OneBranchPipelines/stages/build-linux-single-stage.yml
Outdated
Copy link
Copy Markdown
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 67.9%
mssql_python.row.py: 70.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 74.6%
mssql_python.pybind.connection.connection.cpp: 76.2%
mssql_python.__init__.py: 77.3%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 85.3%🔗 Quick Links
|
Sorry, something went wrong.
Comment thread
OneBranchPipelines/build-release-package-pipeline.yml
Outdated
Saurabh Singh (saurabh500)
approved these changes
Apr 29, 2026
Gaurav Sharma (bewithgaurav)
approved these changes
Apr 30, 2026
Copy link
Copy Markdown
Contributor
Author
|
/azp run |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sorry, something went wrong.
gargsaumya
added a commit
that referenced
this pull request
May 20, 2026
### Work Item / Issue Reference > [AB#45159](https://sqlclientdrivers.visualstudio.com/mssql-python/_sprints/taskboard/mssql-python%20Team/mssql-python/Rubidium/May%202026?workitem=45159) ------------------------------------------------------------------- ### Summary **Enhancements** - #548 — manylinux_2_28 build targets for RHEL 8 / glibc 2.28 - #542 — macOS universal2 wheel for Python 3.10 - #526 — UTF-16 string handling via simdutf - #528 — Optimized execute() hot path - #567 — Azure Linux installation docs **Bug Fixes** - #562 — Login failures now raise mssql_python exception instead of RuntimeError - #568 — GIL released during blocking SQLSetConnectAttr calls - #541 — GIL released during blocking ODBC statement/fetch/transaction calls - #560 — executemany RuntimeError when decimals change signs - #495 — Inconsistent CP1252 VARCHAR retrieval Windows vs Linux - #559 — BulkCopy empty string in NVARCHAR(MAX)/VARCHAR(MAX) (via mssql_py_core 0.1.4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request adds support for building and testing Python wheels on the manylinux_2_28 (glibc 2.28, AlmaLinux 8 / RHEL 8 compatible) platform for both x86_64 and ARM64 architectures. The changes ensure that the build pipeline, Docker image selection, and all related scripts handle the new platform in the same way as the existing manylinux (now clarified as manylinux_2_34) support.
Platform support enhancements:
Script and build logic updates: