CHORE: Couple mssql-python to mssql-python-odbc==18.6.2 - #687
Merged
Jahnvi Thakkar (jahnvi480) merged 2 commits intoJul 23, 2026
Merged
CHORE: Couple mssql-python to mssql-python-odbc==18.6.2#687Jahnvi Thakkar (jahnvi480) merged 2 commits into
Jahnvi Thakkar (jahnvi480) merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add exact-pinned mssql-python-odbc==18.6.2 to install_requires so mssql-python pulls the standalone ODBC Driver 18 package. Loader remains fallback-safe (uses bundled libs when the external package is absent/incomplete). AB#46586
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR couples mssql-python to the standalone ODBC driver binary distribution by adding a pinned mssql-python-odbc==18.6.2 dependency to setup.py, so the driver binaries can be resolved via a separate wheel as part of the ODBC package-split release.
Changes:
- Add mssql-python-odbc==18.6.2 to install_requires in setup.py.
Sorry, something went wrong.
Comment thread
setup.py
Gaurav Sharma (bewithgaurav)
previously approved these changes
Jul 22, 2026
Copy link
Copy Markdown
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 59.9%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 76.1%
mssql_python.pybind.connection.connection.cpp: 76.2%
mssql_python.__init__.py: 77.3%
mssql_python.row.py: 77.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.connection.py: 83.6%
mssql_python.logging.py: 85.5%🔗 Quick Links
|
Sorry, something went wrong.
Jahnvi Thakkar (jahnvi480)
requested review from
Gaurav Sharma (bewithgaurav) and
Copilot
July 22, 2026 10:49
Comment thread
setup.py
Gaurav Sharma (bewithgaurav)
approved these changes
Jul 23, 2026
Subrata (subrata-ms)
approved these changes
Jul 23, 2026
Merged
Subrata (subrata-ms)
added a commit
that referenced
this pull request
Jul 24, 2026
### Work Item / Issue Reference > [AB#46627](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/46627) ------------------------------------------------------------------- ### Summary Release mssql-python v1.12.0. Version bump to 1.12.0. Updates `mssql_python/__init__.py`, `setup.py`, and `PyPI_Description.md`. Bundled `mssql_py_core` bumped from 0.1.6 to 0.1.7. #### Enhancements - **Standalone `mssql-python-odbc` package** — ODBC driver binaries are now also published as a separate, pure-data companion package `mssql-python-odbc` (import name `mssql_python_odbc`, version 18.6.2). `mssql-python` declares it in `install_requires` and prefers the external package at import time, falling back to the still-bundled `libs/` tree so existing installs keep working (#663, #687). #### Bug Fixes - **Bulk copy connection timeout** — `cursor.bulkcopy()` now forwards the cursor's connection timeout (from `connect(timeout=X)`) into the underlying `mssql_py_core` connection, instead of always using the hardcoded 15s default (#650, issue #626). - **Bulk copy of custom CLR UDT columns** — Fixed `Protocol Error: Unsupported TDS type for bulk copy: 0xF0` on `cursor.bulkcopy()` into custom (non-spatial) CLR UDT columns; UDT columns are now mapped to `varbinary(max)` on the wire (#688, via `mssql_py_core` 0.1.7, issue #667). #### Version Bump - `mssql_python/__init__.py`: `__version__ = "1.12.0"` - `setup.py`: `version="1.12.0"` - `PyPI_Description.md`: `## What's new in v1.12.0` section refreshed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request updates the packaging configuration in setup.py to improve dependency management and avoid conflicts between distributions. The main changes ensure that the mssql_python_odbc package is no longer included directly in this distribution, but is instead required as an explicit dependency.
Dependency management improvements: