FEAT: x86_64 (Intel) Support for MacOS - #82
Merged
Gaurav Sharma (bewithgaurav) merged 5 commits intoJun 19, 2025
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
/azp run |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sorry, something went wrong.
gargsaumya
requested changes
Jun 19, 2025
Comment thread
mssql_python/pybind/ddbc_bindings_mac.cpp
gargsaumya
previously approved these changes
Jun 19, 2025
### Summary This pull request adds a new job to the `pr-validation-pipeline.yml` file to enable running Python tests on macOS. The job includes steps for setting up the environment, installing dependencies, building bindings, running tests with coverage, and publishing results. Some Docker-related steps are commented out for now. ### Additions to the pipeline: * **New job for macOS testing**: Added a `PytestOnMacOS` job to the pipeline, which uses the `macos-latest` image to run Python tests. * **Python environment setup**: Configured the job to use Python 3.13.5 and installed dependencies from `requirements.txt`. * **Build and test execution**: - Built pybind bindings via `build.sh`. - Ran `pytest` with coverage and published the results. ### Commented-out Docker-related steps: * Steps for installing and configuring Docker on macOS, including setting up Colima and running an SQL Server container, are included but commented out for now. ### Issue Reference Fixes [AB#37749](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/37749) ### Checklist - [x] **Tests Passed** (if applicable) - [x] **Code is formatted** - [x] **Docs Updated** (if necessary) ### Testing Performed <!-- How was this fix tested? --> - [x] Unit Tests
Sumit Sarabhai (sumitmsft)
previously approved these changes
Jun 19, 2025
gargsaumya
previously approved these changes
Jun 19, 2025
Gaurav Sharma (bewithgaurav)
changed the base branch from
bewithgaurav/row_cursor_mac
to
main
June 19, 2025 12:42
Gaurav Sharma (bewithgaurav)
dismissed stale reviews from gargsaumya and Sumit Sarabhai (sumitmsft)
June 19, 2025 12:42
The base branch was changed.
Copy link
Copy Markdown
Collaborator
Author
|
Changed the base branch to main now that previous branch is shipped, will target main now. |
Sorry, something went wrong.
Sumit Sarabhai (sumitmsft)
approved these changes
Jun 19, 2025
gargsaumya
approved these changes
Jun 19, 2025
Gaurav Sharma (bewithgaurav)
added a commit
that referenced
this pull request
Jul 4, 2026
the arm64 libodbcinst.2.dylib and libltdl.7.dylib were already @loader_path (committed that way in #82), so the fix commit left them untouched. re-sign and commit them too so all six bundled macOS dylibs are the canonical output of a single configure_dylibs.sh run rather than a mix of #82-era and new signatures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces license files for the Microsoft ODBC Driver 18 for SQL Server and updates the README.md for mssql_python/pybind to clarify supported architectures and improve build instructions.
License File Additions:
Documentation Updates:
Issue Reference
Fixes AB#34976
Checklist
Testing Performed