chore: explicit timeout config for send - #2900
Merged
Adam Gastineau (agg23) merged 8 commits intoJun 25, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Adam Gastineau (agg23)
force-pushed
the
explicit-timeout-config
branch
from
64e12e4 to
07834ba
Compare
June 24, 2025 18:18
Comment thread
playwright/_impl/_connection.py
Outdated
Dmitry Gozman (dgozman)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I started to annotate places that now have a timeout, but previously did not, but there are too many. Could you please align with Node.js to avoid behavior changes?
Sorry, something went wrong.
Comment thread
playwright/_impl/_clock.py
Outdated
Comment thread
playwright/_impl/_connection.py
Outdated
Comment thread
playwright/_impl/_element_handle.py
Outdated
Comment thread
playwright/_impl/_fetch.py
Outdated
Comment thread
playwright/_impl/_fetch.py
Outdated
Comment thread
playwright/_impl/_frame.py
Outdated
Dmitry Gozman (dgozman)
approved these changes
Jun 25, 2025
Comment thread
playwright/_impl/_connection.py
Outdated
Comment thread
playwright/_impl/_frame.py
Outdated
Dmitry Gozman (dgozman)
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #2892. Remove implicit timeout information in server calls and make it explicit and required.