This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Prefer stub content when stub is available - #1845
Open
Mikhail Arkhipov (MikhailArkhipov) wants to merge 136 commits into
Open
Prefer stub content when stub is available#1845Mikhail Arkhipov (MikhailArkhipov) wants to merge 136 commits into
Mikhail Arkhipov (MikhailArkhipov) wants to merge 136 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
added 30 commits
September 30, 2019 12:03
added 19 commits
December 4, 2019 11:22
Remove readonly
Remove readonly
…etes presions analysis session that was canceled may still be running.
Copy link
Copy Markdown
Member
|
How does this work with partial stubs? Our typeshed is still an old copy (missing 3.8 stuff), and we bundle small targeted stubs for numpy. Does this only apply for stubs shipped directly with libraries? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Change is limited to typeshed modules only. Numpy is not there so it is analyzed same way as before. Only stubs from typeshed are considered. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Regular on import numpy Analysis complete: 933 modules in 8785.63 ms. Analysis version 1624 of 932 entries has been completed in 5851.16 ms. with stubsOnly: true Analysis complete: 933 modules in 6685.23 ms. Analysis version 1640 of 933 entries has been completed in 4446.48 ms. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
import sys
import os
import datetimeRegular: Analysis complete: 348 modules in 6099.82 ms. Analysis version 574 of 309 entries has been completed in 2703.78 ms. with stubsOnly: true Analysis complete: 348 modules in 3079.24 ms. Analysis version 574 of 334 entries has been completed in 1461.81 ms. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1821
Prefer stub content when stub is available. Don't eval content beyond documentation. Increases analysis speed 20-50% depending on how many stubs are available.