Make sure tuple protocol name does not ignore unknown parameter types - #206
Make sure tuple protocol name does not ignore unknown parameter types#206Mikhail Arkhipov (MikhailArkhipov) merged 5 commits into
Conversation
Sorry, something went wrong.
| return sb.ToString(); | ||
| } | ||
|
|
||
| private string GetParameterString(AnalysisValue[] sets) { |
There was a problem hiding this comment.
you can reuse the same StringBuilder here.
Sorry, something went wrong.
There was a problem hiding this comment.
Good point
Sorry, something went wrong.
| return "?"; | ||
| } | ||
| var sb = new StringBuilder(); | ||
| if (sets.Length > 1) { |
There was a problem hiding this comment.
This can be simplified:
If (sets.Length == 1) {
sb.Append(sets[0] is IHasQualifiedName qn ? qn.FullyQualifiedName : sets[0].ShortDescription)
} else {
// remaining code
}
Sorry, something went wrong.
| } | ||
| for (var i = 0; i < sets.Length; i++) { | ||
| if (i > 0) { | ||
| sb.Append(", "); |
There was a problem hiding this comment.
", " or ","?
Sorry, something went wrong.
There was a problem hiding this comment.
", " more readable
Sorry, something went wrong.
| // Enumerate manually since SelectMany drops empty/unknown values | ||
| var sb = new StringBuilder("tuple["); | ||
| for (var i = 0; i < _values.Length; i++) { | ||
| if (i > 0) { |
There was a problem hiding this comment.
We can have an extension method for this:
https://github.com/Microsoft/RTVS/blob/master/src/Common/Core/Impl/Extensions/StringBuilderExtensions.cs
Sorry, something went wrong.
Make sure tuple protocol name does not ignore unknown parameter types
Additional fix for #173 since 'SelectMany' drops empty sequences and tuples lose arguments of unknown type making them look like they have fewer arguments.