Fix settings retrieval - #2113
Conversation
Sorry, something went wrong.
| var rootSection = token?["settings"]; | ||
| var pythonSection = rootSection?["python"]; | ||
| var pythonSection = await GetPythonConfigurationAsync(cancellationToken); | ||
| if (pythonSection == null) { |
There was a problem hiding this comment.
Why didn't this check work before? I'd think that if it was sending a null set of settings, we'd be able to see that and skip entirely.
Sorry, something went wrong.
There was a problem hiding this comment.
didChangeConfiguration is supposed to send object that contains changed settings. Root is settings. It started coming empty like
{
settings {
}
}
Sorry, something went wrong.
There was a problem hiding this comment.
Let me check in my R extension... I tried to comment out what you suggested in core ext but it didn't fix it. This change is more of a quick fix, I don't know actual reason things changed.
Sorry, something went wrong.
There was a problem hiding this comment.
Empty would certainly mean empty (since we're getting the whole object), but it's definitely strange that it'd be sending empty unless my hack to the core extension to send null is being converted somewhere in the chain to {}...
Now that I look, that hack only appears in the node code, so commenting it out wouldn't really do anything, yeah...
Sorry, something went wrong.
|
In favor of microsoft/vscode-python#13511 |
Sorry, something went wrong.
Something changed (in the core extension?) so all didChangeConfiguration come with empty settings object. Switching to explicit settings retrieval.