Bug fixes - #418
Conversation
Sorry, something went wrong.
Jake Bailey (jakebailey)
left a comment
There was a problem hiding this comment.
Unless there's something else you want to address, LGTM.
Sorry, something went wrong.
| public override IEnumerable<ILocationInfo> Locations => _original.Locations?.MaybeEnumerate(); | ||
|
|
||
| public override string Name => _original == null ? base.Name : this._original.Name; | ||
| public override string Name => _original == null ? base.Name : _original.Name; |
There was a problem hiding this comment.
Why in this case we call base.Name, and in previous explicitly return empty enumerable instead of calling base.Locations, which also returns empty enumerable?
Sorry, something went wrong.
There was a problem hiding this comment.
Good question. No idea.
Sorry, something went wrong.
| return Enumerable.Empty<ILocationInfo>(); | ||
| } | ||
| return defns.Definitions.Select(l => l.GetLocationInfo()).Where(l => l != null); | ||
| return defns.Definitions.Select(l => l.GetLocationInfo()).ExcludeDefault(); |
There was a problem hiding this comment.
Looks like we have two almost identical methods: ExcludeDefaults and WhereNotNull.
Sorry, something went wrong.
There was a problem hiding this comment.
Yes ExcludeDefault came from RTVS extensions, looks like WhereNotNull is local thing
Sorry, something went wrong.
Fixes #397 (remove name protocol from tuple)
Fixes #383 (do not return nulls, return empty sets)
Fixes #378 (null check)
Fixes #379 (explicit protocol comparison)