This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Use culture-dependent string for decimals in RuntimeMetadataTests - #339
Merged
Brianna Marshall (bamarsha) merged 2 commits intoAug 18, 2020
Merged
Use culture-dependent string for decimals in RuntimeMetadataTests#339Brianna Marshall (bamarsha) merged 2 commits into
Brianna Marshall (bamarsha) merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Brianna Marshall (bamarsha)
requested review from
Andres Paz (anpaz),
Cassandra Granade (cgranade) and
Raphael Koh (theRoughCode)
August 14, 2020 23:31
Copy link
Copy Markdown
Contributor
|
Oh that's interesting, I didn't know decimals are represented differently based on locale. This LGTM, thanks Sarah! |
Sorry, something went wrong.
Raphael Koh (theRoughCode)
approved these changes
Aug 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetRuntimeMetadata returns strings containing decimals in the format of the current culture, so 2.1 would become "2.1" in an English culture but "2,1" in a German culture, for example. However, the tests use a hard-coded string "2.1", causing the tests to fail when the current culture uses a comma for decimals. While the tests pass on the build servers because they use an English culture, they can fail when run locally during development.
This PR might not be the best solution - maybe GetRuntimeMetadata should return a culture-invariant string, or all the unit tests should automatically run in the invariant culture regardless of local settings - but it does work around the immediate issue for me.