FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Regenerate Libraries by ScottCarda-MS · Pull Request #464 · microsoft/qsharp-runtime · GitHub

This repository was archived by the owner on Jan 12, 2024. It is now read-only.
/ qsharp-runtime Public archive

Regenerate Libraries - #464

Draft
Scott Carda (ScottCarda-MS) wants to merge 12 commits into
mainfrom
sccarda/RegenerateLibraries
ConversationCommits (12)ChecksFiles changed
Draft

Regenerate Libraries#464
Scott Carda (ScottCarda-MS) wants to merge 12 commits into
mainfrom
sccarda/RegenerateLibraries

Conversation

Scott Carda (ScottCarda-MS) commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Scott Carda (ScottCarda-MS) changed the title Sccarda/regenerate libraries Regenerate Libraries Dec 17, 2020
Bettina Heim (bettinaheim) reviewed Dec 23, 2020
View reviewed changes
Comment thread src/Simulation/CsharpGeneration/RewriteStep.fs
| true, outputType -> outputType = AssemblyConstants.QsharpExe
| _ -> false

if isExe then

Bettina Heim (bettinaheim) Dec 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The logic for determining whether to emit C# for a particular source (whether source code or an assembly reference) is handled by GenerateCodeForSource. Please adapt it there rather than adding an additional branching here.

Bettina Heim (bettinaheim) commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Scott Carda (@ScottCarda-MS) I believe this is a change that will be needed to enable turning on monomorphization by default, correct? Shall we keep this PR, or shall we close it and you'll set up a new one on top of all the latest changes?

Scott Carda (ScottCarda-MS) commented Mar 31, 2021

Copy link
Copy Markdown
Contributor Author

Scott Carda (@ScottCarda-MS) I believe this is a change that will be needed to enable turning on monomorphization by default, correct? Shall we keep this PR, or shall we close it and you'll set up a new one on top of all the latest changes?

Bettina Heim (@bettinaheim) I'd like to keep it around if it is not too much trouble. It serves as a good reminder to me for what needs to be picked back up when I finally get back to this point in the work stack. Otherwise I will lose more context on the task.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Stefan J. Wernli (swernli) Awaiting requested review from swernli swernli will be requested when the pull request is marked ready for review swernli is a code owner
1 more reviewer
Bettina Heim (bettinaheim) bettinaheim left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL