FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed JSX context-sensitive children discrimination for generic signatures by Andarist · Pull Request #2803 · microsoft/typescript-go · GitHub

/ typescript-go Public

Fixed JSX context-sensitive children discrimination for generic signatures - #2803

Merged
Jake Bailey (jakebailey) merged 4 commits into
microsoft:mainfrom
Andarist:fix/contextually-typed-jsx-children
Feb 17, 2026
ConversationCommits (4)ChecksFiles changed
Merged

Fixed JSX context-sensitive children discrimination for generic signatures#2803
Jake Bailey (jakebailey) merged 4 commits into
microsoft:mainfrom
Andarist:fix/contextually-typed-jsx-children

Conversation

Mateusz Burzyński (Andarist) commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #2802
fixes #2797

Mateusz Burzyński (Andarist) commented Feb 17, 2026
View reviewed changes
Comment thread internal/checker/relater.go Outdated
Mateusz Burzyński (Andarist) force-pushed the fix/contextually-typed-jsx-children branch from 23d7c91 to 847b3fc Compare February 17, 2026 19:59
Mateusz Burzyński (Andarist) commented Feb 17, 2026
View reviewed changes
Comment thread testdata/baselines/reference/compiler/jsxFunctionTypeChildren.types
>(props) => <div>{props.locale}</div> : (props: { locale: string; children: {}; }) => JSX.Element
>props : { locale: string; children: {}; }
>(props) => <div>{props.locale}</div> : (props: BaseProps) => JSX.Element
>props : BaseProps

Mateusz Burzyński (Andarist) Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this matched the explicit children prop variant below this. Strada also has a discrepancy: https://www.typescriptlang.org/play/?ts=6.0.0-dev.20260217#code/JYWwDg9gTgLgBAKjgQwM5wEoFNkGN4BmUEIcARFDvmQNwBQdMAnmFnAEJpYAKxY6AXjgBvOABsIuZGKwAuOKhhRgAOwDmcAL71GLNrwj8APABU4WAB4wsKgCbpOqHn1QA+OEOF04cXAAtgMVtKFXkACjAXeRMASg93bDwYADpE-AA5CFssek04ADI4Ex1s3DFkSjgCAFcVfGAIFTgAYRIwU3MrG3sOLgN+VwiouH7UU1cY+TSUgCkAZQANZIBRGRAbGB1cRsU4ACMweUdnQ0ERcUlpOXIbMi0tnfgsMQ84I1bwEWTvg81XYSGpziAncRlswAAbv9IqdkhIpDJNEYAPTgqFI5EfMCuejI5E+AmEonEwkAPQA-HRtipds8AEyvd5tL4-MB5fyBYI2AQAmH8YGgtHQlxwy6IlFCvLInF0PEk+UKxVwCl0IA

I think this is a clear improvement

Anders Hejlsberg (ahejlsberg) Feb 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, yes, the ObjectFlagsNonInferrableType flag wasn't being propagated. Nice!

Jake Bailey (jakebailey) Feb 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Worth fixing in Strada?

Anders Hejlsberg (ahejlsberg) Feb 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would just leave Strada alone for now.

Jake Bailey (jakebailey) added this pull request to the merge queue Feb 17, 2026
Merged via the queue into microsoft:main with commit c2908f5 Feb 17, 2026
20 checks passed
Copilot AI mentioned this pull request Feb 19, 2026
Merged
Anders Hejlsberg (ahejlsberg) mentioned this pull request Feb 19, 2026
Closed
Copilot AI pushed a commit that referenced this pull request Feb 25, 2026
Fixed JSX context-sensitive children discrimination for generic signa…
bc945df 
…tures (#2803)
Birk Skyum (birkskyum) mentioned this pull request May 2, 2026
Closed
Jake Bailey (jakebailey) pushed a commit to jakebailey/TypeScript that referenced this pull request Aug 13, 2026
Fixed JSX context-sensitive children discrimination for generic signa…
025b9ae 
…tures (microsoft/typescript-go#2803)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Anders Hejlsberg (ahejlsberg) ahejlsberg approved these changes
Jake Bailey (jakebailey) jakebailey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

Back | FazBrowse Home | New Git URL