Handle localization path casing generically - #14669
Merged
Sean McManus (sean-mcmanus) merged 1 commit intoAug 12, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 12, 2026 19:45
View session
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the import_edge_strings localization-import script to locate cpfeui.dll.lcl via case-insensitive matching, avoiding locale-specific casing hacks and making Linux imports resilient to vc/VC directory casing differences.
Changes:
- Replace the hardcoded locale-specific VC/vc vs vc/vc path selection with a case-insensitive glob search for vc/vc/cpfeui.dll.lcl.
- Add explicit failure when the localization file is missing or when multiple matches exist (ambiguous casing/layout).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Colen Garoutte-Carson (Colengms)
approved these changes
Aug 12, 2026
Sean McManus (sean-mcmanus)
marked this pull request as ready for review
August 12, 2026 20:19
Sean McManus (sean-mcmanus)
deleted the
seanmcm/devbox2-wsl/agent35/localization-path-casing
branch
August 12, 2026 20:20
Sean McManus (sean-mcmanus)
added a commit
that referenced
this pull request
Aug 21, 2026
* Validate Yarn lockfile selectors (#14663) * Fix IntelliSense translation strings. (#14668) * Fix IntelliSense translation strings. * Handle localization path casing generically (#14669) * Update changelog and version for 1.33.8 (#14671) * Fix configuration path regex escaping (#14674) * Update inactive regions to support column granularity (#14667) Co-authored-by: @8prashant (Prashant Kumar Rai) * Bump the github-actions group with 2 updates (#14678) Bumps the github-actions group with 2 updates: [github/codeql-action/init](https://github.com/github/codeql-action) and [github/codeql-action/analyze](https://github.com/github/codeql-action). Updates `github/codeql-action/init` from 4.37.4 to 4.37.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f205ea1...5595cca) Updates `github/codeql-action/analyze` from 4.37.4 to 4.37.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f205ea1...5595cca) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action/analyze dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Upgrade nanoid to 3.3.18 (#14690) * Fix SimpleCppProject test setup (#14687) * Update IntelliSense localization strings (#14676) * Ignore process wait test helper (#14694) * Retry OneLocBuild dependency installation (#14697) * Add localized warning for disabled browse database (#14683) * Add localized browse database warning * Clarify browse warning translator hint --------- Co-authored-by: Colen Garoutte-Carson <49173979+Colengms@users.noreply.github.com> * Harden Linux gdb installation (#14695) * Fix configuration path diagnostic ranges (#14679) * Bump the github-actions group with 2 updates (#14698) Bumps the github-actions group with 2 updates: [github/codeql-action/init](https://github.com/github/codeql-action) and [github/codeql-action/analyze](https://github.com/github/codeql-action). Updates `github/codeql-action/init` from 4.37.6 to 4.37.7 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5595cca...ff2f1c6) Updates `github/codeql-action/analyze` from 4.37.6 to 4.37.7 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5595cca...ff2f1c6) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.37.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action/analyze dependency-version: 4.37.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update changelog and version for 1.34.0 (#14700) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Colen Garoutte-Carson <49173979+Colengms@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use case-insensitive path matching when locating cpfeui.dll.lcl so localization imports work on Linux regardless of the vc directory casing. Missing or ambiguous matches now fail explicitly instead of requiring a locale-specific casing exception.
This is a follow-up to #14668 requested by Colen.
Validation