| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@microsoft-github-policy-service agree |
Sorry, something went wrong.
|
Thanks, this is a reasonable addition and the trailing-separator approach is backward compatible. One blocker and two smaller asks before merge: Windows separator gap. The typical config form is !${workspaceFolder}/build/classes/ — after resolution that's an absolute path with forward slashes and a trailing /. Since it's absolute, path.join is skipped, so on Windows exclude.endsWith('\\') is false and exact-match silently never triggers. A Windows user would have to hand-write backslashes. Suggest making the check separator-agnostic and running it before normalization: if (/[\\/]$/.test(exclude)) {
exclude = exclude.slice(0, -1);
isDirect = true;
} else {
isDirect = this.isFilePath(exclude);
}Docs. The trailing-slash convention isn't discoverable — can you update java.debugger.launch.classPaths.exclude and modulePaths.exclude in package.nls.json to mention it? It's also slightly counter-intuitive (a trailing slash usually implies a directory/prefix, here it means exact match), so a clear note helps. Test. A small unit test covering the new exact-match path in filterExcluded would be good given this logic is filesystem-sensitive and currently untested. |
Sorry, something went wrong.
|
Changyong Gong (@chagong) I finally got around to addressing the (very good!) feedback :) Can you re-take a peek? |
Sorry, something went wrong.
| let exclude = p.slice(1); | ||
| let isDirect: boolean; | ||
|
|
||
| if (/[\\/]$/.test(exclude)) { |
There was a problem hiding this comment.
before normalization, and using the exact code-block suggested, per feedback!
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
I was having cases where filters were matching inappropriately, for example with composite builds. This lets you have an exact match syntax. I know it's a bit niche, but I do think it's useful/I personally use it!