Handling undefined values in summarize notifications tool - #6421
Merged
Aiday Marlen Kyzy (aiday-mar) merged 9 commits intoOct 25, 2024
Merged
Handling undefined values in summarize notifications tool#6421Aiday Marlen Kyzy (aiday-mar) merged 9 commits into
Aiday Marlen Kyzy (aiday-mar) merged 9 commits into
Conversation
Aiday Marlen Kyzy (aiday-mar)
changed the base branch from
main
to
release/0.100
October 25, 2024 09:07
Aiday Marlen Kyzy (aiday-mar)
requested review from
Alex Ross (alexr00) and
Ladislau Szomoru (lszomoru)
October 25, 2024 09:07
Aiday Marlen Kyzy (aiday-mar)
marked this pull request as ready for review
October 25, 2024 09:07
Comment thread
src/lm/tools/fetchNotificationTool.ts
Alex Ross (alexr00)
requested changes
Oct 25, 2024
Comment thread
src/lm/tools/summarizeNotificationsTool.ts
Outdated
Comment thread
src/lm/tools/fetchNotificationTool.ts
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review! I made the requested changes |
Sorry, something went wrong.
Alex Ross (alexr00)
previously approved these changes
Oct 25, 2024
Alex Ross (alexr00)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good!
Sorry, something went wrong.
Comment thread
src/lm/tools/summarizeNotificationsTool.ts
Outdated
This was referenced Oct 25, 2024
Alex Ross (alexr00)
approved these changes
Oct 25, 2024
Alex Ross (alexr00)
added a commit
that referenced
this pull request
Oct 28, 2024
* Inaccurate result when asking for authored issues (#6419) Part of #6362 * handling undefined values * changing the order of the response text and tool command result * undo change in search tools * removing the changing of order * review comments * plolishing * merging return statements * pushing the new text model part into the summarize tool result --------- Co-authored-by: Alex Ross <alros@microsoft.com>
Alex Ross (alexr00)
added a commit
that referenced
this pull request
Oct 28, 2024
* Inaccurate result when asking for authored issues (#6419) Part of #6362 * handling undefined values * changing the order of the response text and tool command result * undo change in search tools * removing the changing of order * review comments * plolishing * merging return statements * pushing the new text model part into the summarize tool result --------- Co-authored-by: Alex Ross <alros@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.