Allow verified GitHub emails when none are private - #6921
Conversation
Sorry, something went wrong.
See microsoft#6916. If users haven't opted-in to use private email, still allow all secondary email addresses to be used. The REST response shows these email records with `"visibility": null`.
Kevin Abel (kabel)
left a comment
There was a problem hiding this comment.
The noreply address suffix may not work as expected on GitHub Enterprise Server. I no longer have access to a enterprise server to verify what the noreply address is there (if it's customized for the on-premise instance).
Sorry, something went wrong.
Alex Ross (alexr00)
left a comment
There was a problem hiding this comment.
Kevin Abel (@kabel), thanks for this PR. I'm likely going to have to release with bug #6916, today, but I'll make a recovery release with this fix tomorrow.
Sorry, something went wrong.
| // sort the primary email to the first index | ||
| return data.filter(email => email.visibility === 'public' || email.email.toLowerCase().endsWith('@users.noreply.github.com')).sort((a, b) => +b.primary - +a.primary).map(email => email.email); | ||
| const hasPrivate = data.some(email => email.visibility === 'private'); | ||
| return data.filter(email => hasPrivate ? email.email.endsWith('@users.noreply.github.com') : email.verified) |
There was a problem hiding this comment.
The GitHub API is unclear, but I think this fix makes sense.
Sorry, something went wrong.
|
/azp run |
Sorry, something went wrong.
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sorry, something went wrong.
See #6916.
If users haven't opted-in to use private email, still allow all secondary email addresses to be used. The REST response shows these email records with "visibility": null.