Ignore FS errors from stat() in some cases. - #10021
Merged
Eric Snow (ericsnowcurrently) merged 3 commits intoFeb 10, 2020
Merged
Ignore FS errors from stat() in some cases.#10021Eric Snow (ericsnowcurrently) merged 3 commits into
Eric Snow (ericsnowcurrently) merged 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Eric Snow (ericsnowcurrently)
requested a review
from Kim-Adeline Miguel (kimadeline)
February 10, 2020 18:41
Copy link
Copy Markdown
|
Kudos, SonarCloud Quality Gate passed!
|
Sorry, something went wrong.
Don Jayamanne (DonJayamanne)
approved these changes
Feb 10, 2020
Eric Snow (ericsnowcurrently)
removed the request for review
from Kim-Adeline Miguel (kimadeline)
February 10, 2020 18:59
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #10021 +/- ##
==========================================
+ Coverage 61.19% 61.21% +0.02%
==========================================
Files 564 564
Lines 30147 30152 +5
Branches 4561 4561
==========================================
+ Hits 18448 18458 +10
+ Misses 10667 10659 -8
- Partials 1032 1035 +3
Continue to review full report at Codecov.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #9901)
The earlier FS code ignored errors in a couple of situations. Recent changes inadvertently stopped ignoring them. This change restores the earlier behavior (and adds logging of the errors).