Clear variables when restarting regardless if visible or not - #10117
Merged
Rich Chiodo (rchiodo) merged 1 commit intoFeb 13, 2020
Merged
Clear variables when restarting regardless if visible or not#10117Rich Chiodo (rchiodo) merged 1 commit into
Rich Chiodo (rchiodo) merged 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Rich Chiodo (rchiodo)
requested review from
David Kutugata (DavidKutu),
Don Jayamanne (DonJayamanne) and
Ian Huff (IanMatthewHuff)
February 13, 2020 21:43
Copy link
Copy Markdown
|
Kudos, SonarCloud Quality Gate passed!
|
Sorry, something went wrong.
David Kutugata (DavidKutu)
approved these changes
Feb 13, 2020
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #10117 +/- ##
==========================================
- Coverage 61.33% 61.31% -0.02%
==========================================
Files 567 567
Lines 30648 30650 +2
Branches 4393 4394 +1
==========================================
- Hits 18797 18793 -4
- Misses 10873 10878 +5
- Partials 978 979 +1
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Rich Chiodo (rchiodo)
added a commit
that referenced
this pull request
Feb 15, 2020
Rich Chiodo (rchiodo)
added a commit
that referenced
this pull request
Feb 18, 2020
* Better messaging on notebook fail (#10056) * Install jupyter instead of installing kernel spec (#10080) * Install jupyter instead of installing kernel spec For #10071 * Eliminate variable value when computing data frame info (#10081) * Fix ndarray types to be viewable again (#10093) * Eliminate variable value when computing data frame info * Fix ndarrays to work again Add test to make sure we don't regress this again * Rchiodo/kernel telemetry (#10115) * Add duration to select local/remote kernel * Add notebook language telemetry * Add news entries * #9883 telemetry * News entry * Another spot for kernel spec failure * Add telemetry on product install * Fix install telemetry * Undo launch.json change * Handle other cases * Better way to handle case * Wrong event for jupyter install * Fix unit tests * Clear variables when restarting regardless if visible or not (#10117) * Use different method for checking if kernelspec is available (#10114) * Use different method for checking if kernelspec is available * Fix unit tests * More logging for kernelspec problems (#10132) * More logging for kernelspec problems * Actually capture the exception on the new code * Not actually using output if first exception still there. * Actually only return output on one of the expected calls. * Fix nightly flake * Check our saved jupyter interpreters before allowing any of them to be used as active interpreters (#10113) * Update changelog and package.json * Missing part of changelog * Fix tests and linter problems Co-authored-by: Ian Huff <ian.huff@gmail.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9991
We should clear variables regardless of whether or not the variable explorer is open.
Also need to post a restart kernel message to the UI when restarting in the native editor.