FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Run prettier on our yaml, json and md files by kimadeline · Pull Request #10871 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Run prettier on our yaml, json and md files - #10871

Merged
Kim-Adeline Miguel (kimadeline) merged 3 commits into
microsoft:masterfrom
kimadeline:format-non-ts-files
Apr 1, 2020
ConversationCommits (3)ChecksFiles changed
Merged

Run prettier on our yaml, json and md files#10871
Kim-Adeline Miguel (kimadeline) merged 3 commits into
microsoft:masterfrom
kimadeline:format-non-ts-files

Conversation

Kim-Adeline Miguel (kimadeline) commented Mar 30, 2020 •
edited
Loading

Copy link
Copy Markdown

Except for:

  • src/test (but reformat .vscode/settings.json)
  • src/testMultiRootWkspc (but reformat .vscode/settings.json)
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

Kim-Adeline Miguel (kimadeline) added the no-changelog No news entry required label Mar 30, 2020
Kim-Adeline Miguel (kimadeline) changed the title Run prettier on our yaml and md files (except for what's in tests/) Run prettier on our yaml, json and md files Mar 30, 2020

Codecov (codecov-io) commented Mar 30, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #10871 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10871      +/-   ##
==========================================
- Coverage   60.69%   60.65%   -0.04%     
==========================================
  Files         580      580              
  Lines       31512    31530      +18     
  Branches     4480     4480              
==========================================
  Hits        19125    19125              
- Misses      11417    11433      +16     
- Partials      970      972       +2
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
...interpreter/locators/services/KnownPathsService.ts 49.05% <0.00%> (-1.93%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/featureDeprecationManager.ts 40.90% <0.00%> (-0.63%) ⬇️
...rpreter/locators/services/baseVirtualEnvService.ts 28.07% <0.00%> (-0.51%) ⬇️
src/client/linters/lintingEngine.ts 20.00% <0.00%> (-0.21%) ⬇️
.../client/testing/common/managers/baseTestManager.ts 45.13% <0.00%> (-0.18%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10a89d...3c94e51. Read the comment docs.

Rich Chiodo (rchiodo) approved these changes Mar 30, 2020
View reviewed changes

Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

sonarqubecloud Bot commented Mar 31, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

Kim-Adeline Miguel (kimadeline) commented Apr 1, 2020

Copy link
Copy Markdown
Author

Finally the single workspace tests stopped timing out 🙏

Kim-Adeline Miguel (kimadeline) merged commit 4f774d9 into microsoft:master Apr 1, 2020
Kim-Adeline Miguel (kimadeline) deleted the format-non-ts-files branch April 1, 2020 17:19
lock Bot locked as resolved and limited conversation to collaborators Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Brett Cannon (brettcannon) brettcannon approved these changes
Rich Chiodo (rchiodo) rchiodo approved these changes
Don Jayamanne (DonJayamanne) Awaiting requested review from DonJayamanne
Karthik Nadig (karthiknadig) Awaiting requested review from karthiknadig

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL