FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix background (again) for ipywidgets by rchiodo · Pull Request #11062 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Fix background (again) for ipywidgets - #11062

Merged
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/ipywidgets_background
Apr 9, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Fix background (again) for ipywidgets#11062
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/ipywidgets_background

Conversation

Rich Chiodo (rchiodo) commented Apr 9, 2020

Copy link
Copy Markdown

For #11060

I had removed this by accident on my refactor for how widgets were rendered.

Also fixed a problem with the functional tests running with real jupyter (caused by the IInterpreterSecurity stuff). Kartik Raj (@karrtikr) you fixed the functional tests when running without jupyter, but it's a little bit more tricky than that. Some of our services a registered differently when using real jupyter (Nightly Flake tests)

Rich Chiodo (rchiodo) self-assigned this Apr 9, 2020
Rich Chiodo (rchiodo) commented Apr 9, 2020
View reviewed changes
Comment thread src/test/datascience/dataScienceIocContainer.ts
InterpeterHashProviderFactory,
InterpeterHashProviderFactory
);
this.serviceManager.addSingleton<IInterpreterSecurityService>(

Rich Chiodo (rchiodo) Apr 9, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Kartik Raj (@karrtikr) unfortunately the real interpreter services are registered when we use real jupyter, so these additions were in the wrong spot. They had to fall under the if for when not using the real jupyter.

Kartik Raj (karrtikr) Apr 10, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

unfortunately the real interpreter services are registered

I see. But do these real interpreter services do not need to register IInterpreterSecurityService? Or was it the case that it was being registered twice?

Rich Chiodo (rchiodo) Apr 10, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It was being registered twice when using real jupyter (causing an ambiguous match exception)

sonarqubecloud Bot commented Apr 9, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

Rich Chiodo (rchiodo) merged commit d96be50 into master Apr 9, 2020
Rich Chiodo (rchiodo) deleted the rchiodo/ipywidgets_background branch April 9, 2020 23:13
Rich Chiodo (rchiodo) added a commit that referenced this pull request Apr 9, 2020
Fix background (again) for ipywidgets (#11062)
57d5871

Rich Chiodo (rchiodo) commented Apr 9, 2020

Copy link
Copy Markdown
Author

Going to port this to release

Rich Chiodo (rchiodo) added a commit that referenced this pull request Apr 10, 2020
Fix background (again) for ipywidgets (#11062) (#11064)
0ef5dba
lock Bot locked as resolved and limited conversation to collaborators Apr 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Ian Huff (IanMatthewHuff) Awaiting requested review from IanMatthewHuff
Don Jayamanne (DonJayamanne) Awaiting requested review from DonJayamanne
Kartik Raj (karrtikr) Awaiting requested review from karrtikr
1 more reviewer
David Kutugata (DavidKutu) DavidKutu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Rich Chiodo (rchiodo)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL