FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix arrowing down through cells by rchiodo · Pull Request #11095 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Fix arrowing down through cells - #11095

Merged
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/arrow_down
Apr 11, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Fix arrowing down through cells#11095
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/arrow_down

Conversation

Rich Chiodo (rchiodo) commented Apr 10, 2020

Copy link
Copy Markdown

For #11094

Rich Chiodo (rchiodo) self-assigned this Apr 10, 2020

sonarqubecloud Bot commented Apr 10, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

Ian Huff (IanMatthewHuff) approved these changes Apr 10, 2020
View reviewed changes

Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rich Chiodo (@rchiodo) Maybe add a test as we've regressed this once now?

Codecov (codecov-io) commented Apr 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #11095 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11095      +/-   ##
==========================================
- Coverage   61.42%   61.39%   -0.04%     
==========================================
  Files         597      597              
  Lines       32756    32761       +5     
  Branches     4631     4633       +2     
==========================================
- Hits        20121    20114       -7     
- Misses      11619    11629      +10     
- Partials     1016     1018       +2
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
...ence/ipywidgets/localWidgetScriptSourceProvider.ts 88.13% <0.00%> (-3.39%) ⬇️
...t/common/application/webPanels/webPanelProvider.ts 32.14% <0.00%> (-2.48%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/application/types.ts 100.00% <0.00%> (ø)
src/client/datascience/activation.ts 94.44% <0.00%> (+0.15%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af7c29...9d3e163. Read the comment docs.

Rich Chiodo (rchiodo) merged commit 49f2c4c into master Apr 11, 2020
Rich Chiodo (rchiodo) added a commit that referenced this pull request Apr 11, 2020
Fix arrowing down through cells (#11095)
4ccac22
Rich Chiodo (rchiodo) deleted the rchiodo/arrow_down branch April 13, 2020 16:06
lock Bot locked as resolved and limited conversation to collaborators Apr 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Ian Huff (IanMatthewHuff) IanMatthewHuff approved these changes
Don Jayamanne (DonJayamanne) Awaiting requested review from DonJayamanne
Jim Griesmer (greazer) Awaiting requested review from greazer
David Kutugata (DavidKutu) Awaiting requested review from DavidKutu

Assignees

Rich Chiodo (rchiodo)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL