FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes for UI issues by rchiodo · Pull Request #11130 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Fixes for UI issues - #11130

Merged
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/icon_spacing
Apr 13, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Fixes for UI issues#11130
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/icon_spacing

Conversation

Rich Chiodo (rchiodo) commented Apr 13, 2020

Copy link
Copy Markdown

For #10464, #10465

Change icon spacing and font for toolbar

Rich Chiodo (rchiodo) self-assigned this Apr 13, 2020

sonarqubecloud Bot commented Apr 13, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

Don Jayamanne (DonJayamanne) approved these changes Apr 13, 2020
View reviewed changes
Comment thread src/datascience-ui/native-editor/nativeEditor.less

.native-editor-celltoolbar-middle .image-button {
margin-right: 8px;
margin-right: 3px;

Don Jayamanne (DonJayamanne) Apr 13, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Personally I prefer margin: 4px 3px.

Comment thread src/datascience-ui/interactive-common/common.css

.toolbar-menu-bar .image-button {
margin-right: 12px;
margin-top: 8px;

Don Jayamanne (DonJayamanne) Apr 13, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Or margin: 8px 7px 9px 7px

Codecov (codecov-io) commented Apr 13, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #11130 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11130      +/-   ##
==========================================
- Coverage   61.47%   61.44%   -0.03%     
==========================================
  Files         597      597              
  Lines       32801    32801              
  Branches     4640     4640              
==========================================
- Hits        20163    20154       -9     
- Misses      11622    11629       +7     
- Partials     1016     1018       +2
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
...ence/ipywidgets/localWidgetScriptSourceProvider.ts 88.13% <0.00%> (-3.39%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56051b8...3c70d67. Read the comment docs.

Rich Chiodo (rchiodo) merged commit 3a29293 into master Apr 13, 2020
Rich Chiodo (rchiodo) deleted the rchiodo/icon_spacing branch April 13, 2020 19:11
Rich Chiodo (rchiodo) added a commit that referenced this pull request Apr 13, 2020
Fixes for UI issues (#11130)
438aa3d
lock Bot locked as resolved and limited conversation to collaborators Apr 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Don Jayamanne (DonJayamanne) DonJayamanne approved these changes
Ian Huff (IanMatthewHuff) Awaiting requested review from IanMatthewHuff
Jim Griesmer (greazer) Awaiting requested review from greazer
+1 more reviewer
David Kutugata (DavidKutu) DavidKutu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Rich Chiodo (rchiodo)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL