FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove all other version of debugpy by karthiknadig · Pull Request #11689 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Remove all other version of debugpy - #11689

Merged
Karthik Nadig (karthiknadig) merged 4 commits into
microsoft:masterfrom
karthiknadig:issue11686
May 8, 2020
ConversationCommits (4)ChecksFiles changed
Merged

Remove all other version of debugpy#11689
Karthik Nadig (karthiknadig) merged 4 commits into
microsoft:masterfrom
karthiknadig:issue11686

Conversation

Karthik Nadig (karthiknadig) commented May 8, 2020

Copy link
Copy Markdown
Member

For #10945, #11686

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

It was easier to get rid of the two versions of the debuggers (which we wanted to do anyway #10945). Since this issue occurs with the current stable release as well, I am not sure we should push this to release branch immediately. We could take this in the bug fix release, and it will give this change enough bake time.

This comment has been minimized.

Sign in to view

Codecov (codecov-io) commented May 8, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #11689 into master will increase coverage by 0.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11689      +/-   ##
==========================================
+ Coverage   60.60%   61.06%   +0.46%     
==========================================
  Files         627      632       +5     
  Lines       33865    34584     +719     
  Branches     4763     4938     +175     
==========================================
+ Hits        20523    21118     +595     
- Misses      12355    12440      +85     
- Partials      987     1026      +39
Impacted Files Coverage Δ
src/client/debugger/extension/adapter/factory.ts 96.42% <100.00%> (-0.45%) ⬇️
...ient/debugger/extension/adapter/remoteLaunchers.ts 100.00% <100.00%> (ø)
src/client/logging/formatters.ts 58.53% <0.00%> (-1.47%) ⬇️
src/client/common/types.ts 100.00% <0.00%> (ø)
src/client/common/logger.ts 100.00% <0.00%> (ø)
src/client/logging/trace.ts 82.05% <0.00%> (ø)
src/client/logging/index.ts 100.00% <0.00%> (ø)
src/client/logging/levels.ts 61.11% <0.00%> (ø)
src/client/datascience/jupyter/kernels/helpers.ts 87.50% <0.00%> (ø)
src/client/logging/_global.ts 85.24% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d816dc5...2042ba9. Read the comment docs.

Pavel Minaev (int19h) reviewed May 8, 2020
View reviewed changes
Comment thread build/ci/templates/test_phases.yml Outdated

# Install the requirements for the Python or the system tests. This includes the supporting libs that
# we ship in our extension such as PTVSD, DEBUGPY and Jedi.
# we ship in our extension such as PTVSD and Jedi.

Pavel Minaev (int19h) May 8, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Was this meant to remove ptvsd, rather?

Karthik Nadig (karthiknadig) May 8, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No. That will be a separate change.

Karthik Nadig (karthiknadig) May 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am going to put this back, since I need to install debugpy for 2.7 tests and the install script does not work with it.

sonarqubecloud Bot commented May 8, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

Karthik Nadig (karthiknadig) marked this pull request as ready for review May 8, 2020 17:39
Karthik Nadig (karthiknadig) merged commit 258c28c into microsoft:master May 8, 2020
Kartik Raj (karrtikr) pushed a commit that referenced this pull request May 8, 2020
Revert "Remove all other version of debugpy (#11689)"
e0cfbea 
This reverts commit 258c28c.
Kartik Raj (karrtikr) mentioned this pull request May 8, 2020
Closed
Karthik Nadig (karthiknadig) deleted the issue11686 branch May 12, 2020 19:05
lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Rich Chiodo (rchiodo) rchiodo approved these changes
+1 more reviewer
Pavel Minaev (int19h) int19h approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL