LGTM but a core member may want to look.

Noticed one thing now that this code is actually running. If you have a bunch of comments in a run-up to the old jediEnabled setting, they get removed on edit. E.g., have:

    // Some
    // Comments
    // To keep
    "python.jediEnabled": false,

Will be removed entirely.

Hmm, I guess it's a known issue with the JSONC parser: microsoft/node-jsonc-parser#10

VS Code doesn't use this lib anymore as far as I know (in favor of some internal settings management), so it's difficult to do this sort of change here with files (rather than setting things via VS Code's APIs).

Sure, although opener of #12429 wanted it removed I think.

I think the main problem was that none of this code was active, so the effect was to not actually move people over to the languageServer setting. Whether or not the old setting is left behind I don't think changes that picture.

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information