FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make trusted message visible on dark backgrounds by joyceerhl · Pull Request #12888 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Make trusted message visible on dark backgrounds - #12888

Merged
Joyce Er (joyceerhl) merged 2 commits into
microsoft:masterfrom
joyceerhl:more-fixes
Jul 10, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Make trusted message visible on dark backgrounds #12888
Joyce Er (joyceerhl) merged 2 commits into
microsoft:masterfrom
joyceerhl:more-fixes

Conversation

Joyce Er (joyceerhl) commented Jul 10, 2020

Copy link
Copy Markdown

For #12866

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

Joyce Er (joyceerhl) added the no-changelog No news entry required label Jul 10, 2020
Joyce Er (joyceerhl) changed the title Make trust message visible Make trusted message visible on dark backgrounds Jul 10, 2020
Joyce Er (joyceerhl) marked this pull request as ready for review July 10, 2020 20:56

sonarqubecloud Bot commented Jul 10, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

Joyce Er (joyceerhl) merged commit a7b70f6 into microsoft:master Jul 10, 2020
Don Jayamanne (DonJayamanne) pushed a commit that referenced this pull request Jul 13, 2020
Make trusted message visible on dark backgrounds (#12888)
acecad7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ian Huff (IanMatthewHuff) IanMatthewHuff approved these changes
Rich Chiodo (rchiodo) rchiodo approved these changes
Don Jayamanne (DonJayamanne) Awaiting requested review from DonJayamanne
+2 more reviewers
David Kutugata (DavidKutu) DavidKutu approved these changes
Kim-Adeline Miguel (kimadeline) kimadeline approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL