Closing a notebook marked as trusted shouldn't trigger the save modal - #12904
Merged
Joyce Er (joyceerhl) merged 1 commit intoJul 13, 2020
Merged
Closing a notebook marked as trusted shouldn't trigger the save modal#12904Joyce Er (joyceerhl) merged 1 commit into
Joyce Er (joyceerhl) merged 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
Kudos, SonarCloud Quality Gate passed!
|
Sorry, something went wrong.
Joyce Er (joyceerhl)
requested review from
a team,
David Kutugata (DavidKutu),
Don Jayamanne (DonJayamanne),
Ian Huff (IanMatthewHuff) and
Rich Chiodo (rchiodo)
and removed request for
a team
July 12, 2020 04:00
Comment thread
src/client/datascience/notebookStorage/notebookModel.ts
| // Dirty state comes from undo. At least VS code will track it that way. However | ||
| // skip file changes as we don't forward those to VS code | ||
| if (change.kind !== 'save' && change.kind !== 'saveAs') { | ||
| if (change.kind !== 'save' && change.kind !== 'saveAs' && change.kind !== 'updateTrust') { |
Copy link
Copy Markdown
There was a problem hiding this comment.
Looks like this is one of those where a test would have been good. No need of tests now.
Sorry, something went wrong.
Don Jayamanne (DonJayamanne)
approved these changes
Jul 13, 2020
Don Jayamanne (DonJayamanne)
pushed a commit
that referenced
this pull request
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #12867
Don't increase model change count when trust updates