FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Limit `python.languageServer` setting scope to `window` by MikhailArkhipov · Pull Request #13246 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Limit python.languageServer setting scope to window - #13246

Merged
Mikhail Arkhipov (MikhailArkhipov) merged 18 commits into
microsoft:masterfrom
MikhailArkhipov:lsset
Aug 4, 2020
ConversationCommits (18)ChecksFiles changed
Merged

Limit python.languageServer setting scope to window#13246
Mikhail Arkhipov (MikhailArkhipov) merged 18 commits into
microsoft:masterfrom
MikhailArkhipov:lsset

Conversation

Mikhail Arkhipov (MikhailArkhipov) commented Aug 3, 2020

Copy link
Copy Markdown

Pylance does not support per-folder LS instances and MPLS v1 does not reliably work in this case anyway. This simplifies transition of setting from v1 to Pylance.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.

- [ ] Has a news entry file (remember to thank yourself!).
- [ ] Appropriate comments and documentation strings in the code.
- [ ] Has sufficient logging.
- [ ] Has telemetry for enhancements.
- [ ] Unit tests & system/integration tests are added/updated.
- [ ] Test plan is updated as appropriate.
- [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
- [ ] The wiki is updated with any design decisions/details.

Mikhail Arkhipov added 18 commits May 5, 2020 21:15
Fix path
04e0b34
Merge branch 'master' of https://github.com/Microsoft/vscode-python
9297d96
Merge branch 'master' of https://github.com/Microsoft/vscode-python
9f3d5ac
Merge branch 'master' of https://github.com/Microsoft/vscode-python
607bf98
Merge branch 'master' of https://github.com/Microsoft/vscode-python
e566214
Actually fix settings
4477900
Add news
d0d50de
Add test
03aa5f9
Format
e4a032f
Suppress 'jediEnabled' removal
27eeec7
Merge branch 'master' of https://github.com/Microsoft/vscode-python
89f432e
Drop survey first launch threshold
3ed655b
Merge branch 'master' of https://github.com/Microsoft/vscode-python
64ac38a
Merge branch 'master' of https://github.com/Microsoft/vscode-python
52a4325
Merge branch 'master' of https://github.com/Microsoft/vscode-python
67d7cb8
Merge branch 'master' of https://github.com/Microsoft/vscode-python
0ce6d91
Merge branch 'master' of https://github.com/Microsoft/vscode-python
571115e
Limit LS to window
38ad0c5
Mikhail Arkhipov (MikhailArkhipov) added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. internal contributor labels Aug 3, 2020

sonarqubecloud Bot commented Aug 3, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

Codecov Comments Bot (codecov-commenter) commented Aug 3, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #13246 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13246      +/-   ##
==========================================
+ Coverage   59.64%   59.80%   +0.15%     
==========================================
  Files         670      670              
  Lines       36830    37235     +405     
  Branches     5188     5286      +98     
==========================================
+ Hits        21968    22268     +300     
- Misses      13770    13833      +63     
- Partials     1092     1134      +42
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/datascience/jupyter/jupyterSession.ts 73.68% <0.00%> (-3.43%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
...science/notebookStorage/notebookStorageProvider.ts 50.00% <0.00%> (-1.73%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
...datascience/interactive-common/notebookProvider.ts 52.50% <0.00%> (-0.52%) ⬇️
...datascience/notebookStorage/nativeEditorStorage.ts 68.13% <0.00%> (-0.47%) ⬇️
src/client/datascience/types.ts 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96044d9...38ad0c5. Read the comment docs.

Mikhail Arkhipov (MikhailArkhipov) added the no-changelog No news entry required label Aug 3, 2020
Mikhail Arkhipov (MikhailArkhipov) marked this pull request as ready for review August 3, 2020 21:56

Jake Bailey (jakebailey) commented Aug 4, 2020

Copy link
Copy Markdown
Member

I'm sure you tested it, but did you notice any oddities? I know we already have loads of settings set to "resource" that really shouldn't be, but are.

Jake Bailey (jakebailey) approved these changes Aug 4, 2020
View reviewed changes

Jake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tested it, seems to work fine in the expected cases.

Mikhail Arkhipov (MikhailArkhipov) merged commit 047d667 into microsoft:master Aug 4, 2020
Kartik Raj (karrtikr) mentioned this pull request Aug 7, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Jake Bailey (jakebailey) jakebailey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL