FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't call acquireVsCodeApi more than once by joyceerhl · Pull Request #14543 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Don't call acquireVsCodeApi more than once - #14543

Merged
Rich Chiodo (rchiodo) merged 3 commits into
release-2020.10from
fix-acquireVSCodeApi
Oct 27, 2020
ConversationCommits (3)ChecksFiles changed
Merged

Don't call acquireVsCodeApi more than once#14543
Rich Chiodo (rchiodo) merged 3 commits into
release-2020.10from
fix-acquireVSCodeApi

Conversation

Joyce Er (joyceerhl) commented Oct 27, 2020 •
edited
Loading

Copy link
Copy Markdown

For https://github.com/microsoft/vscode-python/issues/14535

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

Joyce Er (joyceerhl) added the no-changelog No news entry required label Oct 27, 2020

Codecov (codecov-io) commented Oct 27, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #14543 into release-2020.10 will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-2020.10   #14543   +/-   ##
================================================
  Coverage            59.19%   59.19%           
================================================
  Files                  721      721           
  Lines                40230    40230           
  Branches              5828     5828           
================================================
  Hits                 23813    23813           
  Misses               15155    15155           
  Partials              1262     1262

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd5759...b5ef26d. Read the comment docs.

Joyce Er (joyceerhl) changed the title Use globalThis Don't call acquireVsCodeApi more than once Oct 27, 2020
Joyce Er (joyceerhl) marked this pull request as ready for review October 27, 2020 20:02

sonarqubecloud Bot commented Oct 27, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

Rich Chiodo (rchiodo) merged commit 3e137f2 into release-2020.10 Oct 27, 2020
Rich Chiodo (rchiodo) deleted the fix-acquireVSCodeApi branch October 27, 2020 21:23

Codecov Comments Bot (codecov-commenter) commented Apr 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59%. Comparing base (5fd5759) to head (b5ef26d).

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-2020.10   #14543   +/-   ##
================================================
  Coverage               59%      59%           
================================================
  Files                  721      721           
  Lines                40230    40230           
  Branches              5828     5828           
================================================
  Hits                 23813    23813           
  Misses               15155    15155           
  Partials              1262     1262
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Rich Chiodo (rchiodo) rchiodo approved these changes
Don Jayamanne (DonJayamanne) Awaiting requested review from DonJayamanne
Ian Huff (IanMatthewHuff) Awaiting requested review from IanMatthewHuff
Karthik Nadig (karthiknadig) Awaiting requested review from karthiknadig
+1 more reviewer
David Kutugata (DavidKutu) DavidKutu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL