Add new tryPylance banner experiments - #14759
Merged
Jake Bailey (jakebailey) merged 14 commits intoNov 19, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
adding experimentName to old tryPlance test telemetry
Jake Bailey (jakebailey)
marked this pull request as ready for review
November 18, 2020 20:08
11 tasks
Comment thread
src/client/languageServices/proposeLanguageServerBannerJedi.ts
Outdated
Jake Bailey (jakebailey)
marked this pull request as draft
November 18, 2020 21:08
Jake Bailey (jakebailey)
marked this pull request as ready for review
November 18, 2020 21:55
Kim-Adeline Miguel (kimadeline)
approved these changes
Nov 18, 2020
Comment thread
src/client/languageServices/proposeLanguageServerBanner.ts
Outdated
Comment thread
src/client/languageServices/proposeLanguageServerBanner.ts
Copy link
Copy Markdown
Member
Author
|
OK, I'm an idiot and left a test.only in here, so the tests fail. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Kudos, SonarCloud Quality Gate passed!
|
Sorry, something went wrong.
Mikhail Arkhipov (MikhailArkhipov)
approved these changes
Nov 19, 2020
Jake Bailey (jakebailey)
added a commit
to jakebailey/vscode-python
that referenced
this pull request
Nov 19, 2020
Co-authored-by: Bill Schnurr <bschnurr@microsoft.com>
Karthik Nadig (karthiknadig)
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Nov 19, 2020
Co-authored-by: Bill Schnurr <bschnurr@microsoft.com>
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
Nov 19, 2020
* Add new tryPylance banner experiments (#14759) Co-authored-by: Bill Schnurr <bschnurr@microsoft.com> * Put linter prompt behind experiment (#14731) * Add new linter prompt * Tests * Fix typos * Show linter install message only once. * Add more tests and news * Updates for point release. Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Co-authored-by: Bill Schnurr <bschnurr@microsoft.com>
Kartik Raj (karrtikr)
pushed a commit
to karrtikr/vscode-python
that referenced
this pull request
Nov 21, 2020
Co-authored-by: Bill Schnurr <bschnurr@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #14697 (Bill Schnurr (@bschnurr) is out and we want this in).