Fixes #22 to Detect anaconda from known locations - #221
Fixes #22 to Detect anaconda from known locations #221Don Jayamanne (DonJayamanne) merged 19 commits into
Conversation
| // tslint:disable-next-line:no-require-imports no-var-requires | ||
| const untildify: (value: string) => string = require('untildify'); | ||
|
|
||
| const KNOWN_CONDA_LOCATIONS = ['~/anaconda3/bin/conda', '~/miniconda3/bin/conda']; |
There was a problem hiding this comment.
Brett Cannon (@brettcannon) the more I look at the code, I feel its just not future proof.
What happens when Anaconda4 comes out? Do we add anaconda4, and so on?
Making it dynamic could be slow as well, i.e. looking for directories '~/anaconda*`
Sorry, something went wrong.
There was a problem hiding this comment.
Over the time I've installed different versions of miniconda on my home and work computer, and now I have all these directories: .miniconda2, miniconda, miniconda3.
Sorry, something went wrong.
There was a problem hiding this comment.
I agree about the brittleness going forward. I say just do the glob match; the number of matches for that should be rather small and the number of stat calls to resolve this won't be that high.
Sorry, something went wrong.
There was a problem hiding this comment.
Will go with the hacky approach for now, created an issue to be resolve separately (as I'd need to add an npm package).
#256
Sorry, something went wrong.
| // tslint:disable-next-line:no-require-imports no-var-requires | ||
| const untildify: (value: string) => string = require('untildify'); | ||
|
|
||
| const KNOWN_CONDA_LOCATIONS = ['~/anaconda3/bin/conda', '~/miniconda3/bin/conda']; |
There was a problem hiding this comment.
I agree about the brittleness going forward. I say just do the glob match; the number of matches for that should be rather small and the number of stat calls to resolve this won't be that high.
Sorry, something went wrong.
| .then(interpreters => interpreters.filter(this.isCondaEnvironment)) | ||
| .then(condaInterpreters => this.getLatestVersion(condaInterpreters)) | ||
| .then(condaInterpreter => { | ||
| return condaInterpreter ? path.join(path.dirname(condaInterpreter.path), 'conda.exe') : 'conda'; |
There was a problem hiding this comment.
Isn't assuming conda.exe a Windows-specific thing?
Sorry, something went wrong.
There was a problem hiding this comment.
Should probably change the condition. Currently its implied with the existence of registryLookupForConda
Sorry, something went wrong.
There was a problem hiding this comment.
Fixed
Sorry, something went wrong.
* 'master' of https://github.com/Microsoft/vscode-python: Fixes #56 list all environments (#219) Fixes #57 Disable activation on debugging (#220) Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master: Fix typo in README.md (#252) Disable linter without workspaces (#241)
* upstream/master: Fix feedback service (#246) Fix django context initializer (#248) disable generation of tags file upon extension load (#264)
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.