variable provider for native repl - #24094
Aaron Munger (amunger) merged 26 commits into
Conversation
Sorry, something went wrong.
|
You may need to rebase after this other PR is merged for the Smoke test issue: 2b4c2bf |
Sorry, something went wrong.
| indexedChildrenCount: number; | ||
| } | ||
|
|
||
| interface NotebookVariableProvider { |
There was a problem hiding this comment.
Aaron Munger (@amunger) Does the vscode engine need to be explicitly pinned?
We currently have
"engines": {
"vscode": "^1.94.0-20240913"
},
also saw commit on vscode-distro so I think we are good.
Sorry, something went wrong.
There was a problem hiding this comment.
just has to be beyond that distro commit, and that version is, so it should work
Sorry, something went wrong.
| function wrapScriptInFunction(scriptLines: string[]): string { | ||
| const indented = scriptLines.map((line) => ` ${line}`).join('\n'); | ||
| // put everything into a function scope and then delete that scope | ||
| // TODO: run in a background thread |
There was a problem hiding this comment.
Would running the script in the background give performance benefit?
Sorry, something went wrong.
There was a problem hiding this comment.
having a large number of variables could conceivably block execution as they are collected and putting this operation on a background thread would prevent that. the speed of safeRepr might make that unnecessary though.
Sorry, something went wrong.
fix #24066