Register test commands before first await to prevent activation race condition - #25654
Merged
Eleanor Boyd (eleanorjboyd) merged 6 commits intoDec 18, 2025
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
- Extract command registration logic from UnitTestManagementService into standalone registerTestCommands function - Call registerTestCommands synchronously in activateLegacy before async operations - This ensures commands are available immediately when extension activates, preventing "command not found" errors Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
…vation - Register test services (unitTestsRegisterTypes) before any async operations in extension.ts - Register test commands immediately after service registration, before experimentService.activate() - Remove duplicate registrations from extensionActivation.ts activateLegacy() - This ensures commands are available synchronously when extension activates Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with test command not registering on extension activation
Register test commands before first await to prevent activation race condition
Dec 12, 2025
Eleanor Boyd (eleanorjboyd)
marked this pull request as ready for review
December 12, 2025 21:44
Eleanor Boyd (eleanorjboyd)
enabled auto-merge (squash)
December 12, 2025 21:46
Don’t know how to do this, yet it must be done. (dshvvvshr)
approved these changes
Dec 15, 2025
Raymond Zhao (rzhao271)
approved these changes
Dec 18, 2025
Eleanor Boyd (eleanorjboyd)
deleted the
copilot/fix-configure-test-command
branch
December 18, 2025 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22783 and #21865
The python.configureTests command was registered after multiple async operations during extension activation, creating a race condition where users could invoke the command before it was registered.
Changes
Extract command registration: Created standalone registerTestCommands() function in testing/main.ts containing all test command handlers (Tests_Configure, Tests_CopilotSetup, CopyTestId)
Register synchronously before first await: Moved unitTestsRegisterTypes() and registerTestCommands() to extension.ts immediately after initializeStandard(), before experimentService.activate()
Remove duplicate registrations: Cleaned up original registration in UnitTestManagementService.activate() and activateLegacy()