Switch to queue based execution for executing Python code - #25669
Merged
Anthony Kim (anthonykim1) merged 16 commits intoDec 16, 2025
Merged
Switch to queue based execution for executing Python code#25669Anthony Kim (anthonykim1) merged 16 commits into
Anthony Kim (anthonykim1) merged 16 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Anthony Kim (anthonykim1)
marked this pull request as draft
December 15, 2025 18:29
Comment thread
src/client/common/terminal/service.ts
Outdated
Anthony Kim (anthonykim1)
marked this pull request as ready for review
December 16, 2025 07:30
Anthony Kim (anthonykim1)
requested a review
from Karthik Nadig (karthiknadig)
December 16, 2025 07:30
Anthony Kim (anthonykim1)
marked this pull request as draft
December 16, 2025 17:14
Anthony Kim (anthonykim1)
marked this pull request as ready for review
December 16, 2025 17:40
Anthony Kim (anthonykim1)
enabled auto-merge (squash)
December 16, 2025 17:40
Eleanor Boyd (eleanorjboyd)
approved these changes
Dec 16, 2025
Anthony Kim (anthonykim1)
deleted the
anthonykim1/preventUndefinedShow
branch
December 16, 2025 17:55
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Dec 16, 2025
…25669) Resolves: microsoft/vscode-python-environments#958 Challenge is that sendText would get called when terminal is not ready. And doing `undefined.show()` is the problem. Switching to queue based execution for running REPL commands, which would prevent from us losing the first command as well.
Eleanor Boyd (eleanorjboyd)
added a commit
that referenced
this pull request
Dec 16, 2025
…25671) Resolves: microsoft/vscode-python-environments#958 Challenge is that sendText would get called when terminal is not ready. And doing `undefined.show()` is the problem. Switching to queue based execution for running REPL commands, which would prevent from us losing the first command as well. Co-authored-by: Anthony Kim <62267334+anthonykim1@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: microsoft/vscode-python-environments#958
Challenge is that sendText would get called when terminal is not ready. And doing undefined.show() is the problem.
Switching to queue based execution for running REPL commands, which would prevent from us losing the first command as well.