FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add conditional for Python agent tools by eleanorjboyd · Pull Request #25677 · microsoft/vscode-python · GitHub

Add conditional for Python agent tools - #25677

Merged
Eleanor Boyd (eleanorjboyd) merged 5 commits into
microsoft:mainfrom
eleanorjboyd:spontaneous-flea
Jan 14, 2026
Merged

Add conditional for Python agent tools#25677
Eleanor Boyd (eleanorjboyd) merged 5 commits into
microsoft:mainfrom
eleanorjboyd:spontaneous-flea

Conversation

Copy link
Copy Markdown
Member

fixes #25644

Eleanor Boyd (eleanorjboyd) added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels Dec 16, 2025
Eleanor Boyd (eleanorjboyd) marked this pull request as ready for review December 16, 2025 23:03
vs-code-engineering Bot added this to the December / January 2026 milestone Dec 16, 2025
Eleanor Boyd (eleanorjboyd) added the skip package*.json package.json and package-lock.json don't both need updating label Dec 16, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This solution will break simple prompts such as create a python file to do xyz and verify it works correctly

#25644

The problem here is that the model uses this tool to install npm packages.
Thats wrong.
I would try updating the prompts to include text such as Do NOT use this tool to install npm or other non-python packages

Comment thread package.json Outdated
"required": []
}
},
"when": "editorLangId == python || resourceLangId == python || notebookType == jupyter-notebook"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This would break simple cases like a pomrpt such as create a python/notebook file that does ....

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

gotcha- I was going off of Connor's comment about using a "when" statement but this makes sense

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd suggest tweaking to be more descriptive when not to use this

IMPORTANT: This tool should only be used for Python environments and Python Packages - do not use for non-Python packages.

João Moreno (joaomorenoalt) removed this from the December / January 2026 milestone Jan 5, 2026
Eleanor Boyd (eleanorjboyd) merged commit c8b6f50 into microsoft:main Jan 14, 2026
47 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python install offered in irrelevant case

4 participants


Back | FazBrowse Home | New Git URL