FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow to use Jedi language server in system environment or virtual environments by inochisa · Pull Request #25697 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Allow to use Jedi language server in system environment or virtual environments - #25697

Open
Inochi Amaoto (inochisa) wants to merge 1 commit into
microsoft:mainfrom
inochisa:run-venv-jedi
ConversationCommits (1)ChecksFiles changed
Open

Allow to use Jedi language server in system environment or virtual environments#25697
Inochi Amaoto (inochisa) wants to merge 1 commit into
microsoft:mainfrom
inochisa:run-venv-jedi

Conversation

Inochi Amaoto (inochisa) commented Dec 25, 2025 •
edited by eleanorjboyd
Loading

Copy link
Copy Markdown

As this extension uses an internal Jedi LSP, it is hard for the users to change the jedi setting to adapt various requirements. And in some cases, the user require a specific version of the Jedi, which is hard to change as it is embedded.

Add a new configuration property to allow the users to use Jedi LSP in their system environment or virtual environments, and auto fallback to the internal version if the external version is not found.

fixes: #25722

Inochi Amaoto (inochisa) commented Dec 25, 2025

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Eleanor Boyd (eleanorjboyd) reviewed Jan 8, 2026
View reviewed changes

Eleanor Boyd (eleanorjboyd) left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR! Would be great to get a test for this item and then otherwise a few comments if you could address. Additionally linting is failing if you could get that fixed too- thanks!

Comment thread package.nls.json Outdated
Comment thread python_files/run-jedi-language-server.py Outdated
Comment thread python_files/run-jedi-language-server.py
Eleanor Boyd (eleanorjboyd) added the feature-request Request for new features or functionality label Jan 8, 2026

Eleanor Boyd (eleanorjboyd) commented Jan 8, 2026

Copy link
Copy Markdown
Member

One other question, did you have an issue regarding this feature? We link an issue to track status and the issue usually outlines the problem and steps to reproduce for tracking. I can make one if not

Eleanor Boyd (eleanorjboyd) added the info-needed Issue requires more information from poster label Jan 8, 2026

Inochi Amaoto (inochisa) commented Jan 9, 2026

Copy link
Copy Markdown
Author

Thanks for the PR! Would be great to get a test for this item and then otherwise a few comments if you could address.

I would like to, for the test, I should take a look to see if there is a good way for it.

Additionally linting is failing if you could get that fixed too- thanks!

That's my fault, I forgot to run prettier.

Inochi Amaoto (inochisa) commented Jan 9, 2026

Copy link
Copy Markdown
Author

One other question, did you have an issue regarding this feature? We link an issue to track status and the issue usually outlines the problem and steps to reproduce for tracking. I can make one if not

In fact, there is no direct issue for this, but I got a reminder when I raise the issue davidhalter/jedi#2084, as there is no way for me to test the change.

Eleanor Boyd (eleanorjboyd) mentioned this pull request Jan 9, 2026
Open
Allow to use Jedi language server in system environment or virtual en…
db2dd2b 
…vironments

As this extension uses an internal Jedi LSP, it is hard for the users to
change the jedi setting to adapt various requirements. And in some cases,
the user require a specific version of the Jedi, which is hard to change
as it is embedded.

Add a new configuration property to allow the users to use Jedi LSP in
their system environment or virtual environments, and auto fallback to
the internal version if the external version is not found.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

Inochi Amaoto (inochisa) commented Jan 10, 2026

Copy link
Copy Markdown
Author

Thanks for the PR! Would be great to get a test for this item and then otherwise a few comments if you could address.

I would like to, for the test, I should take a look to see if there is a good way for it.

Any suggestion for the test? I have no idea for this PR as it is very simple. It is just add a new variable and chained to the script.

Inochi Amaoto (inochisa) commented Jan 10, 2026

Copy link
Copy Markdown
Author

Eleanor Boyd (@eleanorjboyd) I also change the key to the python.jedi.useJediInEnvPath, as previous key python.languageServer.useJediInEnvPath is broken after rebasing to main branch. Any idea for this?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Eleanor Boyd (eleanorjboyd) eleanorjboyd left review comments
+1 more reviewer
th30neee th30neee approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

Eleanor Boyd (eleanorjboyd)

Labels

feature-request Request for new features or functionality info-needed Issue requires more information from poster

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow to use Jedi language server in system environment or virtual environments

3 participants

Back | FazBrowse Home | New Git URL