Fix absence of pytest kill in Cancel Test Run - #25932
Open
Eugene Kornykhin (kornevgen) wants to merge 4 commits into
Open
Fix absence of pytest kill in Cancel Test Run#25932Eugene Kornykhin (kornevgen) wants to merge 4 commits into
Eugene Kornykhin (kornevgen) wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
This PR restores initialization of the pytest subprocess handle in the pytest execution adapter so that “Cancel Test Run” can actually terminate an in-progress pytest run (regression described in #21507).
Changes:
- Reintroduces assigning the spawned pytest child process (result?.proc) to a local variable used by the cancellation handler.
| File | Description |
|---|---|
| src/client/testing/testController/pytest/pytestExecutionAdapter.ts | Restores tracking of the pytest child process so cancellation can attempt to kill it. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Low
Sorry, something went wrong.
…ents-pr-25932-update
Re-check the cancellation token after capturing the spawned process so cancellation in the registration-to-assignment window still terminates pytest. Add deterministic regression coverage for that race.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Author
|
@microsoft-github-policy-service agree company="Ivannikov Institute for System Programming of the Russian Academy of Sciences, Moscow, Russia" |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21507
Commit 354fcd6 has removed initialisation of resultProc variable. So cancelling can't kill pytest because resultProc is undefined. PR restores that initialisation.
Tested by click on 'Cancel Test Run'. Reaction on cancelling has appeared immediately.
Label: bug