FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chat: avoid redundant environment tool confirmation by eleanorjboyd · Pull Request #26072 · microsoft/vscode-python · GitHub

chat: avoid redundant environment tool confirmation - #26072

Open
Eleanor Boyd (eleanorjboyd) wants to merge 2 commits into
microsoft:mainfrom
eleanorjboyd:agents/allow-all-tool-cal-issue
Open

chat: avoid redundant environment tool confirmation#26072
Eleanor Boyd (eleanorjboyd) wants to merge 2 commits into
microsoft:mainfrom
eleanorjboyd:agents/allow-all-tool-cal-issue

Conversation

Copy link
Copy Markdown
Member

Summary

  • remove the extra confirmation shown before the Python environment picker
  • preserve the picker's explicit user selection before creating or selecting an environment
  • add regression coverage ensuring the tool does not request confirmation during preparation

Why

The contributed configurePythonEnvironment tool always returned confirmationMessages, which caused Copilot CLI sessions to stop for approval even when Allow all was enabled. The environment picker already requires the user to explicitly choose an environment action, so the preceding confirmation was redundant.

The environment picker already requires an explicit user choice, so an additional tool confirmation blocks Allow All sessions unnecessarily.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary skip-issue-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL